-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Additional logging limitations and control #5888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JohnMcPMS
wants to merge
11
commits into
microsoft:master
Choose a base branch
from
JohnMcPMS:log-limits
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
florelis
previously approved these changes
Nov 20, 2025
| } | ||
| } | ||
|
|
||
| void FileLogger::GetDefaultMaximumFileSize() |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: "get" makes me think it will return something. Maybe SetMaximumFileSizeToDefault()?
florelis
previously approved these changes
Nov 21, 2025
florelis
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
Expands the limitations on log files and allows them to be user configurable.
The existing limit was hardcoded to remove any files over 7 days old. This was enforced by a background thread spun up during process start. This same thread enforces the new limits on the aggregate logging directory, while additional code in the file logger enforces the individual file size limitation.
When new log lines would exceed the maximum file size for an individual file, the stream is repositioned after the initialization portion of the log, a log line is output to indicate the wrap, and the logs continue to overwrite the older data.
--- Copied from the update to
Settings.md---file
The
filesettings control the log files generated by winget during operation. These settings apply to the automatic cleanup that happens whenever a Windows Package Manager process is run. They only apply to the default log location, which contains winget logs, AppInstaller logs (the MSIX install UI), and is the default location where installer logs are placed. The automatic cleanup happens at the beginning of the process, so the log file(s) generated by the current process will not be considered in the limits.ageLimitInDaystotalSizeLimitInMBcountLimitThese settings apply to the log files that winget writes, only as they are being written. They do not apply to files written by installers or the AppInstaller UI.
individualSizeLimitInMB--- End copy from
Settinds.md---Validation
Added new unit tests for various internal functions and file logger.
Manually verified log wrapping.
Microsoft Reviewers: Open in CodeFlow