Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File Overwrite Warning on First Install of Portable App #2327

Closed
Trenly opened this issue Jul 12, 2022 · 2 comments · Fixed by #2375
Closed

File Overwrite Warning on First Install of Portable App #2327

Trenly opened this issue Jul 12, 2022 · 2 comments · Fixed by #2375
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation.
Milestone

Comments

@Trenly
Copy link
Contributor

Trenly commented Jul 12, 2022

Brief description of your issue

When first installing a Portable App, there is a warning displayed that a file is being overwritten, even though it is a clean install (running in windows sandbox)

Steps to reproduce

Unzip the manifest attached;
Install the manifest locally using v1.3 of the winget client

Manifest Files: OO-Software.zip
Log Files: OO-Software.ShutUp10.zip

Expected behavior

No Warning to be shown, as that file shouldn't exist from a clean sandbox install.

Expected Command Line Output from Install
--> Installing WinGet
Tip: you can type 'Update-EnvironmentVariables' to update your environment variables, such as after installing a new software.

--> Configuring Winget
Admin setting enabled.

--> Installing the Manifest 1.9.1431.368

Found ShutUp10++ [OO-Software.ShutUp10] Version 1.9.1431.368
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
Downloading https://dl5.oo-software.com/files/ooshutup10/OOSU10.exe
  ██████████████████████████████  1.58 MB / 1.58 MB
Successfully verified installer hash
Starting package install...
Path environment variable modified; restart your shell to use the new value.
Successfully installed

--> Refreshing environment variables

--> Comparing ARP Entries

DisplayName    DisplayVersion Publisher    ProductCode
-----------    -------------- ---------    -----------
O&O ShutUp10++ 1.9.1431       O&O Software OO-Software.ShutUp10__DefaultSource

Actual behavior

There is a warning shown -

Overwriting existing file:C:\Users\WDAGUtilityAccount\AppData\Local\Microsoft\WinGet\Links\shutup10.exe

Command Line Output from Install
--> Installing WinGet
Tip: you can type 'Update-EnvironmentVariables' to update your environment variables, such as after installing a new software.

--> Configuring Winget
Admin setting enabled.

--> Installing the Manifest 1.9.1431.368

Found ShutUp10++ [OO-Software.ShutUp10] Version 1.9.1431.368
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
Downloading https://dl5.oo-software.com/files/ooshutup10/OOSU10.exe
  ██████████████████████████████  1.58 MB / 1.58 MB
Successfully verified installer hash
Starting package install...
Overwriting existing file:C:\Users\WDAGUtilityAccount\AppData\Local\Microsoft\WinGet\Links\shutup10.exe
Path environment variable modified; restart your shell to use the new value.
Successfully installed

--> Refreshing environment variables

--> Comparing ARP Entries

DisplayName    DisplayVersion Publisher    ProductCode
-----------    -------------- ---------    -----------
O&O ShutUp10++ 1.9.1431       O&O Software OO-Software.ShutUp10__DefaultSource
Screen Capture from Install

image

Environment

PS C:\Users\WDAGUtilityAccount\Desktop\winget-pkgs> winget --info
Windows Package Manager v1.3.1872
Copyright (c) Microsoft Corporation. All rights reserved.

Windows: Windows.Desktop v10.0.19041.1766
System Architecture: X64
Package: Microsoft.DesktopAppInstaller v1.18.1872.0

Logs: %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\DiagOutputDir

Links
---------------------------------------------------------------------------
Privacy Statement   https://aka.ms/winget-privacy
License Agreement   https://aka.ms/winget-license
Third Party Notices https://aka.ms/winget-3rdPartyNotice
Homepage            https://aka.ms/winget
Windows Store Terms https://www.microsoft.com/en-us/storedocs/terms-of-sale
@ghost ghost added the Needs-Triage Issue need to be triaged label Jul 12, 2022
@denelon denelon added Issue-Bug It either shouldn't be doing this or needs an investigation. and removed Needs-Triage Issue need to be triaged labels Jul 12, 2022
@Trenly
Copy link
Contributor Author

Trenly commented Jul 12, 2022

If more manifests are needed for testing - There are extras in the latest commits on these branches
https://github.com/Trenly/winget-pkgs/branches/all?query=Portables

@denelon
Copy link
Contributor

denelon commented Jul 23, 2022

I think we will do a servicing fix to get this into 1.3 after GA, and make sure it gets into the next 1.4 preview.

@denelon denelon added this to the v1.4-Client milestone Jul 23, 2022
@ghost ghost added the In-PR Issue related to a PR label Jul 26, 2022
@ghost ghost added Resolution-Fix-Committed and removed In-PR Issue related to a PR labels Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants