Improve windows-bindgen for std usage
#2610
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisDenton
approved these changes
Aug 16, 2023
Collaborator
ChrisDenton
left a comment
ChrisDenton
left a comment
There was a problem hiding this comment.
This works for me! I've updated my std branch to move more of the config options into the windows_sys.lst file and that seems to be working.
Collaborator
Author
|
Sweet, thanks for checking! |
Collaborator
Author
|
@ChrisDenton I'm preparing a release. |
Collaborator
|
Great! My PR should be ready to go once that's done (give or take some minor tweaks). |
|
Wait a second, maybe fix for microsoft/win32metadata#1680 can be here too? |
Collaborator
Author
|
I'd need another release of the Win32 metadata. I don't think there is one yet with that change. That would also mean a breaking change to the API surface so unless that's really urgent I'd prefer to hold off on that. Thoughts? |
|
In that case, this can wait until next release. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #2609, this update makes the following changes:
SOCKET