Skip to content

Commit d42d304

Browse files
committed
Don't continue the test if MakeTestStruct already failed
This closes a path to a nil-dereference panic when test setup fails. Signed-off-by: Paul "TBBle" Hampson <Paul.Hampson@Pobox.com>
1 parent 56086ce commit d42d304

File tree

3 files changed

+10
-7
lines changed

3 files changed

+10
-7
lines changed

plugins/nat/nat_windows_test.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ func TestNatCmdAdd(t *testing.T) {
2121
testDualStack = (os.Getenv("TestDualStack") == "1")
2222
imageToUse = os.Getenv("ImageToUse")
2323
testNetwork := CreateNatTestNetwork()
24-
pt := util.MakeTestStruct(t, testNetwork, "nat", false, false, "", testDualStack, imageToUse)
25-
pt.RunAll(t)
24+
if pt := util.MakeTestStruct(t, testNetwork, "nat", false, false, "", testDualStack, imageToUse); pt != nil {
25+
pt.RunAll(t)
26+
}
2627
}

plugins/sdnbridge/sdnbridge_windows_test.go

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,8 @@ func TestBridgeCmdAdd(t *testing.T) {
2525
testDualStack = (os.Getenv("TestDualStack") == "1")
2626
imageToUse = os.Getenv("ImageToUse")
2727
testNetwork := CreateBridgeTestNetwork()
28-
pt := util.MakeTestStruct(t, testNetwork, "L2Bridge", true, true, "", testDualStack, imageToUse)
29-
pt.Ipv6Url = os.Getenv("Ipv6UrlToUse")
30-
pt.RunAll(t)
28+
if pt := util.MakeTestStruct(t, testNetwork, "L2Bridge", true, true, "", testDualStack, imageToUse); pt != nil {
29+
pt.Ipv6Url = os.Getenv("Ipv6UrlToUse")
30+
pt.RunAll(t)
31+
}
3132
}

plugins/sdnoverlay/sdnoverlay_windows_test.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ func TestOverlayCmdAdd(t *testing.T) {
3939
testDualStack = (os.Getenv("TestDualStack") == "1")
4040
imageToUse = os.Getenv("ImageToUse")
4141
testNetwork := CreateOverlayTestNetwork()
42-
pt := util.MakeTestStruct(t, testNetwork, "Overlay", true, false, "", testDualStack, imageToUse)
43-
pt.RunAll(t)
42+
if pt := util.MakeTestStruct(t, testNetwork, "Overlay", true, false, "", testDualStack, imageToUse); pt != nil {
43+
pt.RunAll(t)
44+
}
4445
}

0 commit comments

Comments
 (0)