Skip to content

Dipose XmlReaders in Microsoft.TestPlatform.Common.RunSettings #5100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 10, 2024
Merged

Dipose XmlReaders in Microsoft.TestPlatform.Common.RunSettings #5100

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0373bd6
Dipose XmlReaders in Microsoft.TestPlatform.Common.RunSettings
omajid Jun 14, 2024
32e2d0a
Merge branch 'main' into runsettings-xmlreader-dispose
nohwnd Jul 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Microsoft.TestPlatform.Common/RunSettings.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ public void LoadSettingsXml(string settings)
}

using var stringReader = new StringReader(settings);
var reader = XmlReader.Create(stringReader, XmlRunSettingsUtilities.ReaderSettings);
using var reader = XmlReader.Create(stringReader, XmlRunSettingsUtilities.ReaderSettings);
ValidateAndSaveSettings(reader);
}

Expand All @@ -91,7 +91,7 @@ public void LoadSettingsXml(string settings)
public void InitializeSettingsProviders(string settings)
{
using var stringReader = new StringReader(settings);
var reader = XmlReader.Create(stringReader, XmlRunSettingsUtilities.ReaderSettings);
using var reader = XmlReader.Create(stringReader, XmlRunSettingsUtilities.ReaderSettings);
ReadRunSettings(reader);
}

Expand Down