Skip to content

Conversation

@nohwnd
Copy link
Member

@nohwnd nohwnd commented Jun 3, 2024

Description

Use built-in sha1 and slice for id generation.

image
image

Fix https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2050310
Fix microsoft/testfx#2762

@nohwnd nohwnd requested a review from Evangelink as a code owner June 3, 2024 14:20
@nohwnd
Copy link
Member Author

nohwnd commented Jun 3, 2024

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@nohwnd nohwnd changed the title Use array pool for idgenerator Use built in sha1 for id generation Jun 4, 2024
@nohwnd
Copy link
Member Author

nohwnd commented Jun 4, 2024

@Evangelink You are a code owner here, but I am just changing the underlying implementation and no tests were changed, and I also checked that the produced trx from old and new mstest SDK produces the same guids, so all should be good.

@nohwnd nohwnd merged commit d84e6e4 into microsoft:main Jun 4, 2024
@Evangelink
Copy link
Member

@Evangelink You are a code owner here, but I am just changing the underlying implementation and no tests were changed, and I also checked that the produced trx from old and new mstest SDK produces the same guids, so all should be good.

I didn't know I was :D

Thanks for the PR! Looking forward for the perf improvement.

This was referenced Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve performance of ID generation

3 participants