Make VSTest repo buildable in VMR non-source-build #4920
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmitche
reviewed
Mar 6, 2024
mmitche
reviewed
Mar 6, 2024
mmitche
reviewed
Mar 6, 2024
src/Microsoft.TestPlatform.Build/Microsoft.TestPlatform.Build.csproj
Outdated
Show resolved
Hide resolved
mmitche
reviewed
Mar 6, 2024
src/Microsoft.TestPlatform.Build/Microsoft.TestPlatform.Build.csproj
Outdated
Show resolved
Hide resolved
mmitche
reviewed
Mar 6, 2024
src/package/Microsoft.TestPlatform.CLI/Microsoft.TestPlatform.CLI.csproj
Outdated
Show resolved
Hide resolved
mmitche
reviewed
Mar 6, 2024
src/package/Microsoft.TestPlatform.CLI/Microsoft.TestPlatform.CLI.csproj
Outdated
Show resolved
Hide resolved
mmitche
approved these changes
Mar 6, 2024
Member
mmitche
left a comment
mmitche
left a comment
There was a problem hiding this comment.
Changes otherwise look good. Should at least be straight compatible in source-build mode.
Co-authored-by: Matt Mitchell <mmitche@microsoft.com>
Co-authored-by: Matt Mitchell <mmitche@microsoft.com>
…csproj Co-authored-by: Matt Mitchell <mmitche@microsoft.com>
…csproj Co-authored-by: Matt Mitchell <mmitche@microsoft.com>
…CLI.csproj Co-authored-by: Matt Mitchell <mmitche@microsoft.com>
…CLI.csproj Co-authored-by: Matt Mitchell <mmitche@microsoft.com>
nohwnd
approved these changes
Mar 6, 2024
1 task
This was referenced Dec 9, 2025
Open
This was referenced Dec 10, 2025
Open
Open
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to dotnet/source-build#4030