Skip to content

specify Win10 + maxversiontested to enable xaml APIs to be used in tests running under testhost.exe - #4888

Merged
Jakub Jareš (nohwnd) merged 5 commits into
microsoft:mainfrom
ChrisGuzak:master
Feb 26, 2024
Merged

specify Win10 + maxversiontested to enable xaml APIs to be used in tests running under testhost.exe#4888
Jakub Jareš (nohwnd) merged 5 commits into
microsoft:mainfrom
ChrisGuzak:master

Conversation

@ChrisGuzak

Copy link
Copy Markdown
Member

Description

Resolves #4887

Related issue

Kindly link any related issues. E.g. Fixes #xyz.

  • I have ensured that there is a previously discussed and approved issue.

@nohwnd

ghost commented Feb 13, 2024

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

ghost commented Feb 13, 2024

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@nohwnd

ghost commented Feb 15, 2024

Copy link
Copy Markdown
Member

MSLukeWest could you double check this please?

Comment thread src/testhost/app.manifest Outdated
<application>
<!-- Windows 10 -->
<supportedOS Id="{8e0f7a12-bfb3-4fe8-b9a5-48fd50a15a9a}"/>
<maxversiontested Id='10.0.18362.0'/>

ghost Feb 15, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two questions:

  1. Have you confirmed that this doesn't prevent tests from running on RS5 (10.0.17763)?
  2. Should newer versions be added as well? Like 22621 (22H2) and 22631 (23H2)?

ghost Feb 19, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MSLukeWest I've not tested this on older versions, but I understand this will have no effect on them. and newer versions should not be needed... Alexander Sklar (@asklar) can you help me explain why? I recall you (or Gov?) recommended multiple to support running on intermediate versions. I read this bug but don't understand its implications or if it relates to this quirk or others. In your sample you specify one value 10.0.18362.0 (the next highest released build relative to 10.0.18226.0?). In my testing 10.0.18226.0 works on testhost.exe.

          <QUIRK NAME="BlockXamlIslands" CODE_ID="262" ENABLED_VERSION_LT="10.0.18226.0" CONTACT_ALIAS="turekhe" ID="{57064B35-BE7D-4111-A3D0-FF077347F207}">
            <DESCRIPTION>
              Xaml Islands were first shipped in RS5. It was just in preview mode and an incomplete feature.
              However, Islands in 19H1 are more stable and complete. 
              Hence Islands are officially available in 19H1 and onward releases and are blocked on all prior releases.
            </DESCRIPTION>
          </QUIRK>

I'd prefer to go with a single value 10.0.18226.0 to match the quirk, so I've updated this PR to do that.

Let me know what you think (I emailed gov too, does he have a github identity?).

ghost Feb 20, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the original bug I had filed is https://task.ms/33687330
IIUC you have to specify 18362 for xaml islands, and there's another value for segoe ui variable support. Adding a later value doesn't enable the features unlocked by an earlier value which is what makes this maxversiontested flag so confusing. Dustin L. Howett (@DHowett) might remember this more

ghost Feb 21, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

specifying 18226 works in my testing.

ghost Feb 24, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MSLukeWest per the email thread I've updated this change to use 10.0.18362.0, the first public release of the os after 10.0.18226.0.

its ready to go so please merge it.

ghost Feb 24, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, Jakub Jareš (@nohwnd) please merge for us

@nohwnd
Jakub Jareš (nohwnd) enabled auto-merge (squash) February 26, 2024 10:55
@nohwnd
Jakub Jareš (nohwnd) merged commit cf18f60 into microsoft:main Feb 26, 2024
@nohwnd

ghost commented Feb 26, 2024

Copy link
Copy Markdown
Member

Merged, thank you both!

This was referenced Aug 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update maxversiontested to Xaml Islands can be used in a VSTest project

4 participants