specify Win10 + maxversiontested to enable xaml APIs to be used in tests running under testhost.exe - #4888
Conversation
commented
Feb 13, 2024
|
/azp run |
commented
Feb 13, 2024
|
Azure Pipelines successfully started running 1 pipeline(s). |
commented
Feb 15, 2024
|
MSLukeWest could you double check this please? |
| <application> | ||
| <!-- Windows 10 --> | ||
| <supportedOS Id="{8e0f7a12-bfb3-4fe8-b9a5-48fd50a15a9a}"/> | ||
| <maxversiontested Id='10.0.18362.0'/> |
There was a problem hiding this comment.
Two questions:
- Have you confirmed that this doesn't prevent tests from running on RS5 (10.0.17763)?
- Should newer versions be added as well? Like 22621 (22H2) and 22631 (23H2)?
There was a problem hiding this comment.
MSLukeWest I've not tested this on older versions, but I understand this will have no effect on them. and newer versions should not be needed... Alexander Sklar (@asklar) can you help me explain why? I recall you (or Gov?) recommended multiple to support running on intermediate versions. I read this bug but don't understand its implications or if it relates to this quirk or others. In your sample you specify one value 10.0.18362.0 (the next highest released build relative to 10.0.18226.0?). In my testing 10.0.18226.0 works on testhost.exe.
<QUIRK NAME="BlockXamlIslands" CODE_ID="262" ENABLED_VERSION_LT="10.0.18226.0" CONTACT_ALIAS="turekhe" ID="{57064B35-BE7D-4111-A3D0-FF077347F207}">
<DESCRIPTION>
Xaml Islands were first shipped in RS5. It was just in preview mode and an incomplete feature.
However, Islands in 19H1 are more stable and complete.
Hence Islands are officially available in 19H1 and onward releases and are blocked on all prior releases.
</DESCRIPTION>
</QUIRK>I'd prefer to go with a single value 10.0.18226.0 to match the quirk, so I've updated this PR to do that.
Let me know what you think (I emailed gov too, does he have a github identity?).
There was a problem hiding this comment.
the original bug I had filed is https://task.ms/33687330
IIUC you have to specify 18362 for xaml islands, and there's another value for segoe ui variable support. Adding a later value doesn't enable the features unlocked by an earlier value which is what makes this maxversiontested flag so confusing. Dustin L. Howett (@DHowett) might remember this more
There was a problem hiding this comment.
specifying 18226 works in my testing.
There was a problem hiding this comment.
MSLukeWest per the email thread I've updated this change to use 10.0.18362.0, the first public release of the os after 10.0.18226.0.
its ready to go so please merge it.
There was a problem hiding this comment.
Approved, Jakub Jareš (@nohwnd) please merge for us
commented
Feb 26, 2024
|
Merged, thank you both! |
Description
Resolves #4887
Related issue
Kindly link any related issues. E.g. Fixes #xyz.