Skip to content

Improve terminal logger - #4877

Merged
Jakub Jareš (nohwnd) merged 26 commits into
microsoft:mainfrom
nohwnd:terminal-logger-for-vstest
Feb 13, 2024
Merged

Improve terminal logger#4877
Jakub Jareš (nohwnd) merged 26 commits into
microsoft:mainfrom
nohwnd:terminal-logger-for-vstest

Conversation

@nohwnd

Copy link
Copy Markdown
Member

Part of #4843

@nohwnd
Jakub Jareš (nohwnd) marked this pull request as ready for review February 9, 2024 12:37
@nohwnd

ghost commented Feb 12, 2024

Copy link
Copy Markdown
Member Author

/azp run

@azure-pipelines

ghost commented Feb 12, 2024

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@nohwnd

ghost commented Feb 12, 2024

Copy link
Copy Markdown
Member Author

Michael Simons (@MichaelSimons) we are adding some pre-builts exclusions here. Is there anything more that needs to be done?

ghost left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only did a shallow review but LGTM. Let me know if I should pull the code and make some tests to provide a full review.

Comment thread src/vstest.console/Internal/MSBuildLogger.cs
Comment thread src/vstest.console/Internal/MSBuildLogger.cs
Comment thread src/vstest.console/Internal/MSBuildLogger.cs
Comment thread src/vstest.console/Internal/MSBuildLogger.cs Outdated
Comment thread src/vstest.console/Internal/MSBuildLogger.cs Outdated
This was referenced Aug 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants