Conversation
| // case System.Runtime.InteropServices.Architecture.S390x: | ||
| (Architecture)5 => PlatformArchitecture.S390x, | ||
| (Architecture)8 => PlatformArchitecture.Ppc64le, | ||
| (Architecture)9 => PlatformArchitecture.RiscV64, |
There was a problem hiding this comment.
I don't recall but maybe worth it check what we do during the selection of the host for this architecture.
There was a problem hiding this comment.
We do some fallbacks, I cannot really test it since I don't have hardware, but if it is working on s390x or ppc64le it should work for this architecture as well. The rest of the platform special cases x86, x64 and arm64 (e.g. in blame), but not the other ones. So the change here is pretty much the same as what we did for S390x and Ppc64le.
|
Hi @nohwnd, probably you forget to update |
|
@ww898 I see 2 updates to them in this PR. And the build passed (there is roslyn analyzer making sure the files are reflecting what is actually published). Why do you think I forgot to update them? Do you see a mistake, that I don't see? |
|
@nohwnd Sorry, it was my fault. |
3 participants
Description
Add riscv64 architecture to our enums.
Related issue
Fix #4837