Fix Invalid target architecture 'S390x' error #4066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In commit 3ae5c4a ("Add support for s390x processor architecture") support for S390x architecture was provided for .NET6. This is broken in .NET7. Add missing case statements to fix this for S390x and also Power architectures.
|
Approved by Tactics |
|
@nohwnd -- Checking to see if we can expect this to be reviewed and merged in the next few days |
nohwnd
approved these changes
Oct 18, 2022
nohwnd
pushed a commit
to nohwnd/vstest
that referenced
this pull request
Oct 18, 2022
Co-authored-by: Giridhar Trivedi <giridhar.trivedi@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In commit 3ae5c4a ("Add support for s390x processor architecture") support for S390x architecture was provided for .NET6. This is broken in .NET7. Add missing case statements to fix this for S390x and also Power architectures.
Related issue
#2954