-
Notifications
You must be signed in to change notification settings - Fork 340
Restore netcoreapp1.0 support for testhost #2554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a055e62 to
b5ba8f0
Compare
b5ba8f0 to
07d3c8e
Compare
|
All looks OK, but I am converting this to draft, I'll add new targets to NuGet packages and tests and then merge. |
|
Hello @Haplois! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
@sharwell what's the reason for adding/restoring netcoreapp1.0 support? Wondering as netcoreapp1.0 has been EOL for a long time. |
|
@ViktorHofer It allows multi-targeting projects to move forward with adding support for the latest runtime targets without blocking adoption of new targets on the removal of an unrelated one. The issue I hit directly involved analyzer testing for Roslyn analyzers that support Visual Studio 2015, which is still supported. We could carve out slightly different cases over time, where the .NET Framework tools from 2015 keep working but the .NET Core tooling just breaks at some point, but that seemed unnecessary considering the ease with which .NET Core 1.x can be supported by the test runner. |
This pull request updates the build to include netcoreapp1.0 outputs for testhost.exe and testhost.x86.exe. It does not (yet) update tests to cover these cases, or NuGet packaging to include the output binaries.