Skip to content

Conversation

@sharwell
Copy link
Contributor

@sharwell sharwell commented Sep 1, 2020

This pull request updates the build to include netcoreapp1.0 outputs for testhost.exe and testhost.x86.exe. It does not (yet) update tests to cover these cases, or NuGet packaging to include the output binaries.

@sharwell sharwell marked this pull request as ready for review September 8, 2020 22:24
@Haplois Haplois self-requested a review September 9, 2020 00:19
@Haplois Haplois marked this pull request as draft September 9, 2020 00:24
@Haplois
Copy link
Contributor

Haplois commented Sep 9, 2020

All looks OK, but I am converting this to draft, I'll add new targets to NuGet packages and tests and then merge.

@Haplois Haplois marked this pull request as ready for review September 15, 2020 23:05
@ghost
Copy link

ghost commented Sep 15, 2020

Hello @Haplois!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 50e6af6 into microsoft:master Sep 16, 2020
@ViktorHofer
Copy link
Member

ViktorHofer commented Sep 25, 2020

@sharwell what's the reason for adding/restoring netcoreapp1.0 support? Wondering as netcoreapp1.0 has been EOL for a long time.

@sharwell sharwell deleted the fix-netstandard1 branch September 25, 2020 17:04
@sharwell
Copy link
Contributor Author

@ViktorHofer It allows multi-targeting projects to move forward with adding support for the latest runtime targets without blocking adoption of new targets on the removal of an unrelated one. The issue I hit directly involved analyzer testing for Roslyn analyzers that support Visual Studio 2015, which is still supported. We could carve out slightly different cases over time, where the .NET Framework tools from 2015 keep working but the .NET Core tooling just breaks at some point, but that seemed unnecessary considering the ease with which .NET Core 1.x can be supported by the test runner.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants