Skip to content

Replace dotnet.config, with global.json#15449

Merged
nohwnd merged 2 commits into
microsoft:mainfrom
nohwnd:move-to-global-json-for-mtp
Mar 9, 2026
Merged

Replace dotnet.config, with global.json#15449
nohwnd merged 2 commits into
microsoft:mainfrom
nohwnd:move-to-global-json-for-mtp

Conversation

@nohwnd

@nohwnd nohwnd commented Mar 9, 2026

Copy link
Copy Markdown
Member

dotnet.config is no longer suppported way of configuring mtp, replace it with global.json

Description

Please add a meaningful description for this change.
Ensure the PR has required unit tests.

Related issue

Kindly link any related issues. E.g. Fixes #xyz.

  • I have ensured that there is a previously discussed and approved issue.

dotnet.config is no longer suppported way of configuring mtp, replace it with global.json
Copilot AI review requested due to automatic review settings March 9, 2026 09:39

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Replace deprecated dotnet.config-based test runner configuration with global.json, and enforce the intended runner behavior in integration test execution.

Changes:

  • Removed dotnet.config and introduced global.json test.runner configuration.
  • Updated InvokeDotnetTest to create/validate a global.json in the working directory to force vstest.
  • Added a repository-level global.json test.runner value for Microsoft.Testing.Platform.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
test/Microsoft.TestPlatform.TestUtilities/IntegrationTestBase.cs Writes/validates global.json in the working directory to force vstest for integration runs.
global.json Adds test.runner configuration at repo root (set to Microsoft.Testing.Platform).
dotnet.config Removes deprecated test runner configuration file.

Comment thread test/Microsoft.TestPlatform.TestUtilities/IntegrationTestBase.cs
Comment thread test/Microsoft.TestPlatform.TestUtilities/IntegrationTestBase.cs Outdated
Comment thread test/Microsoft.TestPlatform.TestUtilities/IntegrationTestBase.cs
Comment thread test/Microsoft.TestPlatform.TestUtilities/IntegrationTestBase.cs
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings March 9, 2026 11:19

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

Comment thread test/Microsoft.TestPlatform.TestUtilities/IntegrationTestBase.cs
@nohwnd nohwnd enabled auto-merge (squash) March 9, 2026 13:19
@nohwnd nohwnd merged commit 1a566c7 into microsoft:main Mar 9, 2026
6 checks passed
This was referenced May 26, 2026
This was referenced Jul 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants