Merged
Conversation
Member
Author
|
@copilot anything that the previous code handled and that I don't test for in the new code? |
nohwnd
commented
Oct 31, 2025
| // If the char after '\' is a '"', output '"' and skip over to the next char. | ||
| if (index <= args.Length && args[index] == '"') | ||
| { | ||
| currentArg.Append('"'); |
Member
Author
There was a problem hiding this comment.
Main bug was here imho. We handled the quote, but we don't advance to the next character because the logic is trying to be too clever with the \ being or not being doubled.
The " is then processed in the next loop, and stops the string from being quoted, even though the quote was escaped.
Member
Author
|
@copilot anything that the previous code handled and that I don't test for in the new code? |
fhnaseer
approved these changes
Nov 10, 2025
This was referenced Feb 24, 2026
Open
intellitect-bot
pushed a commit
to IntelliTect/EssentialCSharp.Web
that referenced
this pull request
Feb 24, 2026
Updated [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 18.0.1 to 18.3.0. <details> <summary>Release notes</summary> _Sourced from [Microsoft.NET.Test.Sdk's releases](https://github.com/microsoft/vstest/releases)._ ## 18.3.0 ## What's Changed * Fix answer file splitting by @nohwnd in microsoft/vstest#15306 ## Internal fixes and updates * Bump branding to 18.1 by @nohwnd in microsoft/vstest#15286 * Remove stale copy of S.ComponentModel.Composition from testplatform packages by @ViktorHofer in microsoft/vstest#15287 * Update codeflow metadata to fix backflow by @premun in microsoft/vstest#15291 * [main] Update dependencies from devdiv/DevDiv/vs-code-coverage by @dotnet-maestro[bot] in microsoft/vstest#15283 * Update Microsoft.Build.Utilities.Core by @Youssef1313 in microsoft/vstest#15300 * Disable DynamicNative instrumentation by default by @nohwnd in microsoft/vstest#15299 * [main] Source code updates from dotnet/dotnet by @dotnet-maestro[bot] in microsoft/vstest#15293 * [main] Source code updates from dotnet/dotnet by @dotnet-maestro[bot] in microsoft/vstest#15302 * [main] Source code updates from dotnet/dotnet by @dotnet-maestro[bot] in microsoft/vstest#15314 * Delete sha1 custom implementation we are not using for a long time by @nohwnd in microsoft/vstest#15313 * [main] Source code updates from dotnet/dotnet by @dotnet-maestro[bot] in microsoft/vstest#15315 * Update branding to 18.3.0 by @nohwnd in microsoft/vstest#15321 * [main] Update dependencies from devdiv/DevDiv/vs-code-coverage by @dotnet-maestro[bot] in microsoft/vstest#15325 * [main] Update dependencies from dotnet/arcade by @dotnet-maestro[bot] in microsoft/vstest#15264 * Revert adding dotnet_host_path workaround by @nohwnd in microsoft/vstest#15328 * [main] Update dependencies from dotnet/arcade by @dotnet-maestro[bot] in microsoft/vstest#15338 * [main] Source code updates from dotnet/dotnet by @dotnet-maestro[bot] in microsoft/vstest#15322 * [main] Update dependencies from dotnet/arcade by @dotnet-maestro[bot] in microsoft/vstest#15343 * Change PreReleaseVersionLabel from 'preview' to 'release' by @nohwnd in microsoft/vstest#15352 * [rel/18.3] Update dependencies from devdiv/DevDiv/vs-code-coverage by @dotnet-maestro[bot] in microsoft/vstest#15354 * [rel/18.3] Update dependencies from dotnet/arcade by @dotnet-maestro[bot] in microsoft/vstest#15389 * [rel/18.3] Update dependencies from dotnet/arcade by @dotnet-maestro[bot] in microsoft/vstest#15400 * Update build tools to 17.11.48 to be source buildable by @nohwnd in microsoft/vstest#15310 * Disable publishing on RTM by @nohwnd in microsoft/vstest#15296 * Don't access nuget.org for package feeds by @nohwnd in microsoft/vstest#15316 * No nuget access fix tests by @nohwnd in microsoft/vstest#15317 * Disable Dependabot updates in dependabot.yml by @mmitche in microsoft/vstest#15324 ## New Contributors * @premun made their first contribution in microsoft/vstest#15291 Commits viewable in [compare view](microsoft/vstest@v18.0.1...v18.3.0). </details> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This was referenced Feb 24, 2026
Closed
This was referenced Feb 25, 2026
Open
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The code was last touched here #1196 fixing some indeterminate issues with the parsing. Seeing the examples in tests it handles quotes differently and backslashes.
However the code runs out of bounds (not a problem but throws index out of range unnecessarilly).
And fails to recognize
\"that is in quoted string. It detects the\", but the index is not advanced past that", so in the next steps is incorrectly stops being a quoted string and spaces will split the command into more tokens.This is problematic for providing /Tests: which provides the whole test name including spaces etc, in format like this:
The previous logic would split the parameters to be:
And would fail with
Ipsum\")test source not found.New logic correctly splits it to:
I have a much larger file from the issue, but it contains customer data, and the spaces are the only edge case that triggers this problem.
Related issue
https://developercommunity.visualstudio.com/t/vstest-task-fails-with-Unhandled-Except/10527048