Remove stale copy of S.ComponentModel.Composition from testplatform packages#15287
Merged
Remove stale copy of S.ComponentModel.Composition from testplatform packages#15287
Conversation
…ackages S.ComponentModel.Composition is no longer used in testplatform packages, so we can remove the stale copy of it. The assembly that was redistributed targets netstandard2.0 and is a PNSE - throws PlatformNotSupportedException. This proves that the assembly never got loaded and is indeed unused in all cases. This resolves having this stale copy in the SDK layout under i.e. "C:\Program Files\dotnet\sdk\10.0.100-rc.1.25451.107\System.ComponentModel.Composition.dll"
ericstj
approved these changes
Oct 1, 2025
Member
Author
|
gentle ping @nohwnd |
nohwnd
approved these changes
Oct 6, 2025
This was referenced Feb 24, 2026
Open
intellitect-bot
pushed a commit
to IntelliTect/EssentialCSharp.Web
that referenced
this pull request
Feb 24, 2026
Updated [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 18.0.1 to 18.3.0. <details> <summary>Release notes</summary> _Sourced from [Microsoft.NET.Test.Sdk's releases](https://github.com/microsoft/vstest/releases)._ ## 18.3.0 ## What's Changed * Fix answer file splitting by @nohwnd in microsoft/vstest#15306 ## Internal fixes and updates * Bump branding to 18.1 by @nohwnd in microsoft/vstest#15286 * Remove stale copy of S.ComponentModel.Composition from testplatform packages by @ViktorHofer in microsoft/vstest#15287 * Update codeflow metadata to fix backflow by @premun in microsoft/vstest#15291 * [main] Update dependencies from devdiv/DevDiv/vs-code-coverage by @dotnet-maestro[bot] in microsoft/vstest#15283 * Update Microsoft.Build.Utilities.Core by @Youssef1313 in microsoft/vstest#15300 * Disable DynamicNative instrumentation by default by @nohwnd in microsoft/vstest#15299 * [main] Source code updates from dotnet/dotnet by @dotnet-maestro[bot] in microsoft/vstest#15293 * [main] Source code updates from dotnet/dotnet by @dotnet-maestro[bot] in microsoft/vstest#15302 * [main] Source code updates from dotnet/dotnet by @dotnet-maestro[bot] in microsoft/vstest#15314 * Delete sha1 custom implementation we are not using for a long time by @nohwnd in microsoft/vstest#15313 * [main] Source code updates from dotnet/dotnet by @dotnet-maestro[bot] in microsoft/vstest#15315 * Update branding to 18.3.0 by @nohwnd in microsoft/vstest#15321 * [main] Update dependencies from devdiv/DevDiv/vs-code-coverage by @dotnet-maestro[bot] in microsoft/vstest#15325 * [main] Update dependencies from dotnet/arcade by @dotnet-maestro[bot] in microsoft/vstest#15264 * Revert adding dotnet_host_path workaround by @nohwnd in microsoft/vstest#15328 * [main] Update dependencies from dotnet/arcade by @dotnet-maestro[bot] in microsoft/vstest#15338 * [main] Source code updates from dotnet/dotnet by @dotnet-maestro[bot] in microsoft/vstest#15322 * [main] Update dependencies from dotnet/arcade by @dotnet-maestro[bot] in microsoft/vstest#15343 * Change PreReleaseVersionLabel from 'preview' to 'release' by @nohwnd in microsoft/vstest#15352 * [rel/18.3] Update dependencies from devdiv/DevDiv/vs-code-coverage by @dotnet-maestro[bot] in microsoft/vstest#15354 * [rel/18.3] Update dependencies from dotnet/arcade by @dotnet-maestro[bot] in microsoft/vstest#15389 * [rel/18.3] Update dependencies from dotnet/arcade by @dotnet-maestro[bot] in microsoft/vstest#15400 * Update build tools to 17.11.48 to be source buildable by @nohwnd in microsoft/vstest#15310 * Disable publishing on RTM by @nohwnd in microsoft/vstest#15296 * Don't access nuget.org for package feeds by @nohwnd in microsoft/vstest#15316 * No nuget access fix tests by @nohwnd in microsoft/vstest#15317 * Disable Dependabot updates in dependabot.yml by @mmitche in microsoft/vstest#15324 ## New Contributors * @premun made their first contribution in microsoft/vstest#15291 Commits viewable in [compare view](microsoft/vstest@v18.0.1...v18.3.0). </details> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This was referenced Feb 24, 2026
Open
This was referenced Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
S.ComponentModel.Composition is no longer used in testplatform packages, so we can remove the stale copy of it. The assembly that was redistributed targets netstandard2.0 and is a PNSE - throws PlatformNotSupportedException. This proves that the assembly never got loaded and is indeed unused in all cases.
This resolves having this stale copy in the SDK layout under i.e. "C:\Program Files\dotnet\sdk\10.0.100-rc.1.25451.107\System.ComponentModel.Composition.dll" which showed up as a difference in dotnet/source-build#5344