Skip to content

Revert "Build TestPlatform packages in VMR" - #15057

Merged
Jakub Jareš (nohwnd) merged 1 commit into
mainfrom
revert-15055-BuildTestPlatformPackagesInVMR
Apr 22, 2025
Merged

Revert "Build TestPlatform packages in VMR"#15057
Jakub Jareš (nohwnd) merged 1 commit into
mainfrom
revert-15055-BuildTestPlatformPackagesInVMR

Conversation

@ViktorHofer

Copy link
Copy Markdown
Member

Reverts #15055

The packages don't build successfully on non-Windows:

  Microsoft.TestPlatform failed with 1 error(s) (0.1s)
    /home/vihofer/git/vstest/.dotnet/sdk/9.0.104/Sdks/NuGet.Build.Tasks.Pack/buildCrossTargeting/NuGet.Build.Tasks.Pack.targets(221,5): error NU5019: File not found: 'net48\Microsoft.TestPlatform.VsTestConsole.TranslationLayer.xml'.
  Microsoft.TestPlatform.Portable failed with 1 error(s) (0.1s)
    /home/vihofer/git/vstest/.dotnet/sdk/9.0.104/Sdks/NuGet.Build.Tasks.Pack/buildCrossTargeting/NuGet.Build.Tasks.Pack.targets(221,5): error NU5019: File not found: 'net48\Microsoft.TestPlatform.VsTestConsole.TranslationLayer.xml'.

I'm a bit suprised that vstest's CI doesn't build packages on non-Windows. Also, the checked-in nuspecs with the hundreds of lines of assets to include are horrible. They made me open this revert PR instead of attempting to fix the build issue.

@ViktorHofer

Copy link
Copy Markdown
Member Author

Jakub Jareš (@nohwnd)

@nohwnd
Jakub Jareš (nohwnd) merged commit b1b03ee into main Apr 22, 2025
@nohwnd
Jakub Jareš (nohwnd) deleted the revert-15055-BuildTestPlatformPackagesInVMR branch April 22, 2025 11:29
This was referenced Oct 2, 2025
This was referenced Aug 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants