Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add examples / samples back to solution #2341

Closed
nohwnd opened this issue Feb 24, 2020 · 0 comments
Closed

Add examples / samples back to solution #2341

nohwnd opened this issue Feb 24, 2020 · 0 comments

Comments

@nohwnd
Copy link
Member

nohwnd commented Feb 24, 2020

In #2340 I removed samples from the main solution because they were using the versions from the test assets which would prevent the build from finishing, because test assets now build against the results of the main build. I don't think samples should use our complicated build, and instead should pin normal versions from nuget. Add them back in the same solution or in separate solution that will be built on the CI but won't fail the build. Samples are not supposed to be acceptance tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant