Skip to content

Commit

Permalink
Fix yml to generate RTM/stable version & fix symbol check issues (#4600)
Browse files Browse the repository at this point in the history
* [main] Update dependencies from devdiv/DevDiv/vs-code-coverage (#4594)

* Update dependencies from https://dev.azure.com/devdiv/DevDiv/_git/vs-code-coverage build 20230712.2

Microsoft.Internal.CodeCoverage
 From Version 17.8.0-beta.23360.1 -> To Version 17.8.0-beta.23362.2

* Mire

* Update dependencies from https://dev.azure.com/devdiv/DevDiv/_git/vs-code-coverage build 20230712.5

Microsoft.Internal.CodeCoverage
 From Version 17.8.0-beta.23360.1 -> To Version 17.8.1-beta.23362.5

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Jakub Chocholowicz <jachocho@microsoft.com>

* Fix yml to generate RTM/stable version

---------

Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Jakub Chocholowicz <jachocho@microsoft.com>
Co-authored-by: Amaury Levé <amauryleve@microsoft.com>
  • Loading branch information
5 people authored Jul 14, 2023
1 parent d7f4faa commit fab9246
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 4 deletions.
7 changes: 7 additions & 0 deletions azure-pipelines.yml
Original file line number Diff line number Diff line change
Expand Up @@ -58,12 +58,18 @@ variables:
value: False
- name: _InternalBuildArgs
value: ' '
- name: _ReleaseVersionKind
value: ''
# Arcade is using global cache of nugets in non-windows build
# under some circumstances, but we don't respect that in our code and try to find them
# in .packages. Force the location of packages to that folder.
- name: NUGET_PACKAGES
value: '$(Build.SourcesDirectory)/.packages/'

- ${{ if eq(parameters.isRTM, True) }}:
- name: _ReleaseVersionKind
value: release

# Produce real signed binaries for Internal builds
- ${{ if eq(variables._RunAsInternal, True) }}:
# Group gives access to $microsoft-symbol-server-pat and $symweb-symbol-server-pat
Expand All @@ -83,6 +89,7 @@ variables:
- name: _InternalBuildArgs
value: /p:DotNetSignType=$(_SignType)
/p:TeamName=$(_TeamName)
/p:DotNetFinalVersionKind=$(_ReleaseVersionKind)
/p:DotNetPublishUsingPipelines=true
/p:DotNetSymbolServerTokenMsdl=$(microsoft-symbol-server-pat)
/p:DotNetSymbolServerTokenSymWeb=$(symweb-symbol-server-pat)
Expand Down
4 changes: 2 additions & 2 deletions eng/Version.Details.xml
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
<?xml version="1.0" encoding="utf-8"?>
<Dependencies>
<ProductDependencies>
<Dependency Name="Microsoft.Internal.CodeCoverage" Version="17.7.3">
<Dependency Name="Microsoft.Internal.CodeCoverage" Version="17.8.1-beta.23362.5">
<Uri>https://dev.azure.com/devdiv/DevDiv/_git/vs-code-coverage</Uri>
<Sha>8e1aa0711f4efac22e1f1b977cffc517a54ab8af</Sha>
<Sha>2e244945f4192cc5e96aa2e9e6a62f1e47a09ad0</Sha>
</Dependency>
<Dependency Name="Microsoft.Diagnostics.NETCore.Client" Version="0.2.0-preview.23211.1">
<Uri>https://github.com/dotnet/diagnostics</Uri>
Expand Down
4 changes: 2 additions & 2 deletions eng/Versions.props
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,9 @@
<MicrosoftExtensionsDependencyModelPackageVersion>3.0.0</MicrosoftExtensionsDependencyModelPackageVersion>
<MicrosoftExtensionsFileSystemGlobbingVersion>2.0.0</MicrosoftExtensionsFileSystemGlobbingVersion>
<MicrosoftFakesVersion>17.4.0-beta.22478.3</MicrosoftFakesVersion>
<MicrosoftInternalCodeCoverageVersion>17.7.3</MicrosoftInternalCodeCoverageVersion>
<MicrosoftInternalCodeCoverageVersion>17.8.1-beta.23362.5</MicrosoftInternalCodeCoverageVersion>
<MicrosoftNetCompilersToolsetVersion>4.6.0-1.23107.10</MicrosoftNetCompilersToolsetVersion>
<MicrosoftVisualStudioDiagnosticsUtilitiesVersion>17.6.33617.297</MicrosoftVisualStudioDiagnosticsUtilitiesVersion>
<MicrosoftVisualStudioDiagnosticsUtilitiesVersion>17.6.33910.51</MicrosoftVisualStudioDiagnosticsUtilitiesVersion>
<MicrosoftVisualStudioEnterpriseAspNetHelper>$(MicrosoftVisualStudioDiagnosticsUtilitiesVersion)</MicrosoftVisualStudioEnterpriseAspNetHelper>
<MicrosoftVisualStudioInteropVersion>17.3.32622.426</MicrosoftVisualStudioInteropVersion>
<MicrosoftVSSDKBuildToolsVersion>17.4.2116</MicrosoftVSSDKBuildToolsVersion>
Expand Down

0 comments on commit fab9246

Please sign in to comment.