Skip to content

Commit 8a7b327

Browse files
authored
Warning on unsupported tfms (#15072)
* Add warning when restoring old TFM * revert * Revert "revert" This reverts commit 81c7638.
1 parent 43aaae1 commit 8a7b327

File tree

5 files changed

+19
-3
lines changed

5 files changed

+19
-3
lines changed

eng/Versions.props

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
from appending +<commitId>, which breaks DTAAgent.
1414
-->
1515
<IncludeSourceRevisionInInformationalVersion>false</IncludeSourceRevisionInInformationalVersion>
16-
<VersionPrefix>17.14.0</VersionPrefix>
16+
<VersionPrefix>17.14.1</VersionPrefix>
1717
<PreReleaseVersionLabel>release</PreReleaseVersionLabel>
1818
</PropertyGroup>
1919
<PropertyGroup Label="Arcade settings">

eng/verify-nupkgs.ps1

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ function Verify-Nuget-Packages {
1818
Write-Host "Starting Verify-Nuget-Packages."
1919
$expectedNumOfFiles = @{
2020
"Microsoft.CodeCoverage" = 59;
21-
"Microsoft.NET.Test.Sdk" = 15;
21+
"Microsoft.NET.Test.Sdk" = 20;
2222
"Microsoft.TestPlatform" = 619;
2323
"Microsoft.TestPlatform.Build" = 20;
2424
"Microsoft.TestPlatform.CLI" = 481;

src/package/Microsoft.NET.Test.Sdk/Microsoft.NET.Test.Sdk.csproj

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,9 @@
2929
<None Update="Microsoft.NET.Test.Sdk.props">
3030
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
3131
</None>
32+
<None Update="Microsoft.NET.Test.Sdk.targets">
33+
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
34+
</None>
3235
<None Update="netcoreapp\*">
3336
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
3437
</None>

src/package/Microsoft.NET.Test.Sdk/Microsoft.NET.Test.Sdk.nuspec

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,17 @@
2121
<file src="netstandard2.0\netcoreapp\*" target="build\net8.0\" />
2222
<file src="netstandard2.0\netfx\*" target="build\net462\" />
2323

24-
<file src="netstandard2.0\Microsoft.NET.Test.Sdk.props" target="buildMultiTargeting\" />
24+
<file src="netstandard2.0\Microsoft.NET.Test.Sdk.props" target="buildMultiTargeting\net462\" />
25+
<file src="netstandard2.0\Microsoft.NET.Test.Sdk.props" target="buildMultiTargeting\net8.0\" />
2526
<file src="netstandard2.0\Microsoft.NET.Test.Sdk.props" target="build\net8.0\" />
2627
<file src="netstandard2.0\Microsoft.NET.Test.Sdk.props" target="build\net462\" />
2728

29+
<!-- Add incompatibility warning. -->
30+
<file src="netstandard2.0\Microsoft.NET.Test.Sdk.targets" target="buildMultiTargeting\netcoreapp2.0\" />
31+
<file src="netstandard2.0\Microsoft.NET.Test.Sdk.targets" target="build\netcoreapp2.0\" />
32+
<file src="netstandard2.0\Microsoft.NET.Test.Sdk.targets" target="buildMultiTargeting\netstandard2.0\" />
33+
<file src="netstandard2.0\Microsoft.NET.Test.Sdk.targets" target="build\netstandard2.0\" />
34+
2835
<file src="netstandard2.0\_._" target="lib/net8.0" />
2936
<file src="netstandard2.0\_._" target="lib/net462" />
3037
</files>
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
<Project InitialTargets="NonCompatibleTargetFrameworkError_Microsoft_NET_Test_Sdk_net8_0">
2+
<Target Name="NonCompatibleTargetFrameworkError_Microsoft_NET_Test_Sdk_net8_0"
3+
Condition="'$(SuppressTfmSupportBuildWarnings)' == ''">
4+
<Warning Text="Microsoft.NET.Test.Sdk doesn't support $(TargetFramework) and has not been tested with it. Consider upgrading your TargetFramework to net8.0 or later. You may also set &lt;SuppressTfmSupportBuildWarnings&gt;true&lt;/SuppressTfmSupportBuildWarnings&gt; in the project file to ignore this warning and attempt to run in this unsupported configuration at your own risk." />
5+
</Target>
6+
</Project>

0 commit comments

Comments
 (0)