-
Notifications
You must be signed in to change notification settings - Fork 29.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial support for a timeline (file history) view #89262
Conversation
} | ||
} | ||
|
||
function* map<T, TMapped>(source: Iterable<T> | IterableIterator<T>, mapper: (item: T) => TMapped): Iterable<TMapped> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even tho this is workbench-only we don't use "modern" JS because the editor still supports IE11. This should be flagged as TS compile error, no clue why not 🤷♂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also mean to Iterable
and such, basically no globals that IE11 doesn't support (and that cannot be poly-filled)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is dayjs localized across all languages we support? We probably should be rolling our own library here, just for the localization support.
authorEmail?: string | undefined; | ||
authorDate?: Date; | ||
authorName?: string; | ||
authorEmail?: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, I'll wait for this to come in before merging #89005.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The merge probably wouldn't go very well, since I changed the parsing from how it was. But I can easily add commitDate
in if we want.
Cleans up API and removes some unused features (e.g. paging) Adds date formatting Adds loading progress and message Removes lots of console.logs 😁 Adds titles to diffs
8b84b84
to
d6f818b
Compare
Need to revisit how we will handle long running providers
@joaomoreno RE: day.js -- I don't know if they have all the languages we support. I started implementing this myself using the |
This PR fixes #84297
This is just the initial pass at a Timeline view with a registered
TimelineProvider
in the Git extension to provide Git history for the active file.To enable this view, set
"timeline.showView": true