Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #41613 #42259

Merged
merged 1 commit into from
Jan 29, 2018
Merged

Fix #41613 #42259

merged 1 commit into from
Jan 29, 2018

Conversation

svitlana-galianova
Copy link
Contributor

@svitlana-galianova svitlana-galianova commented Jan 27, 2018 •
edited
Loading

@msftclas
Copy link

msftclas commented Jan 27, 2018 •
edited
Loading

CLA assistant check
All CLA requirements met.

@svitlana-galianova
Copy link
Contributor Author

Hello, this is my first PR in VS Code, I would appreciate some guidance in fixing the failed test

@alexdima
Copy link
Member

alexdima commented Jan 29, 2018 •
edited
Loading

I don't think the test failing is related to the proposed change; I believe it is a poor written test that time-outs...

Thank you for your contribution!

@alexdima alexdima merged commit ae1c3b0 into microsoft:master Jan 29, 2018
@alexdima alexdima mentioned this pull request Jan 29, 2018
Closed
@alexdima alexdima added this to the January 2018 milestone Jan 29, 2018
@github-actions github-actions bot locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@alexdima alexdima

Labels
None yet
Projects
None yet
Milestone
January 2018
Development

Successfully merging this pull request may close these issues.
3 participants
@svitlana-galianova @msftclas @alexdima