SCM: Support multiple repositories#31325
Merged
joaomoreno merged 73 commits intomicrosoft:masterfrom Aug 25, 2017
joaomoreno:scm-multiroot
Merged
SCM: Support multiple repositories#31325joaomoreno merged 73 commits intomicrosoft:masterfrom joaomoreno:scm-multiroot
joaomoreno merged 73 commits intomicrosoft:masterfrom
joaomoreno:scm-multiroot
Conversation
53 tasks
jrieken
reviewed
Aug 25, 2017
src/vs/vscode.d.ts
Outdated
|
|
||
| /** | ||
| * The [input box](#SourceControlInputBox) in the Source Control viewlet. | ||
| * The [input box](#SourceControlInputBox) for the last source control |
Member
There was a problem hiding this comment.
Move @deprecated to the top and enclose the rest in ~~ to strike it out
Member
There was a problem hiding this comment.
Maybe also explain the semantics of the 'old' deprecated inputBox, e.g last active one
| * Creates a new [source control](#SourceControl) instance. | ||
| * | ||
| * @param id A unique `id` for the source control. Something short, eg: `git`. | ||
| * @param id An `id` for the source control. Something short, eg: `git`. |
Member
There was a problem hiding this comment.
Should we rename this to type or context key?
Member
Author
There was a problem hiding this comment.
That would make sense. Should I then create a type field in SourceControl and deprecate id?
Member
Author
There was a problem hiding this comment.
Not going with this proposal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.