Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show context menu option to disable empty editor hint #218548

Merged
merged 3 commits into from
Jun 26, 2024

Conversation

joyceerhl
Copy link
Contributor

Fix #213814

@joyceerhl joyceerhl self-assigned this Jun 26, 2024
@joyceerhl joyceerhl enabled auto-merge (squash) June 26, 2024 19:18
@vscodenpa vscodenpa added this to the June 2024 milestone Jun 26, 2024
@@ -145,7 +148,8 @@ export class EmptyTextEditorHintContribution implements IEditorContribution {
this.keybindingService,
this.chatAgentService,
this.telemetryService,
this.productService
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: No injection?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, I can clean that up in debt week

@joyceerhl joyceerhl requested a review from Tyriar June 26, 2024 20:16
@joyceerhl joyceerhl merged commit 9e7cd44 into main Jun 26, 2024
6 checks passed
@joyceerhl joyceerhl deleted the dev/joyceerhl/classic-rook branch June 26, 2024 21:03
aaronchucarroll pushed a commit to aaronchucarroll/vscode that referenced this pull request Jul 10, 2024
…#218548)

* fix: show context menu option to disable empty editor hint

* Fix action name
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Aug 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The empty editor hint should be easily toggled by right clicking on the hint
3 participants