Support custom switch-case indentation #179670
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donaldnevermore
force-pushed
the
fix-indent
branch
from
1c1590a to
441ecd5
Compare
4 tasks
andrewbranch
suggested changes
Apr 12, 2023
extensions/typescript-language-features/src/languageFeatures/fileConfigurationManager.ts
Show resolved
Hide resolved
| @@ -39,6 +39,7 @@ | |||
| "format.semicolons.ignore": "Don't insert or remove any semicolons.", | |||
| "format.semicolons.insert": "Insert semicolons at statement ends.", | |||
| "format.semicolons.remove": "Remove unnecessary semicolons.", | |||
| "format.indentSwitchCase": "Indent case clauses in switch statements.", | |||
There was a problem hiding this comment.
@mjbvz should individual formatter preferences indicate what TS version they require? I’m realizing now I didn’t do that on format.semicolons back when I added that.
There was a problem hiding this comment.
Yes we should call this out. See some of the other setting strings for an example of this
donaldnevermore
force-pushed
the
fix-indent
branch
2 times, most recently
from
5c88cf7 to
39fc097
Compare
andrewbranch
previously approved these changes
Apr 12, 2023
donaldnevermore
force-pushed
the
fix-indent
branch
from
39fc097 to
e546d1d
Compare
donaldnevermore
force-pushed
the
fix-indent
branch
from
e546d1d to
3c97bab
Compare
andrewbranch
approved these changes
Apr 18, 2023
mjbvz
approved these changes
Apr 18, 2023
| @@ -39,6 +39,7 @@ | |||
| "format.semicolons.ignore": "Don't insert or remove any semicolons.", | |||
| "format.semicolons.insert": "Insert semicolons at statement ends.", | |||
| "format.semicolons.remove": "Remove unnecessary semicolons.", | |||
| "format.indentSwitchCase": "Indent case clauses in switch statements.", | |||
There was a problem hiding this comment.
Yes we should call this out. See some of the other setting strings for an example of this
rebornix
approved these changes
Apr 18, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR correlates closely with microsoft/TypeScript#53733 due to API change.
Don't merge before microsoft/TypeScript#53733 gets merged. It won't work until the typescript version in vscode is upgraded.Closes #180239, microsoft/TypeScript#18682