-
Notifications
You must be signed in to change notification settings - Fork 29.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Async textmate tokenization #174443
Async textmate tokenization #174443
Conversation
…xperimental.asyncTokenization" (default false).
As downstream user, what will change in new vscode-textmate? Will it still be UMD & same interface? If there's an issue or PR to discuss or explain it, do please point me there! |
Nothing changes! |
Sounds great! Will unsub, also some relevant xkcd's to reward you: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 This looks really good! I left some comments. Some notes, mostly for myself, to double check before we merge this in:
- check that a text model that is not attached to an editor doesn't do background tokenization
- check that this works OK on the web
- check that vscode-textmate is not loaded if the workbench comes up without an editor
- create build and check that this works in a built product. I think it will definitely not work because we don't package textmate.worker.ts for shipping.
src/vs/workbench/services/textMate/browser/textMateTokenizationFeature.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/services/textMate/browser/workerHost/textMateWorkerHost.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/services/textMate/browser/worker/textMateWorkerModel.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/services/textMate/browser/worker/textMateWorkerModel.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/services/textMate/browser/worker/textMateWorkerModel.ts
Show resolved
Hide resolved
src/vs/workbench/services/textMate/browser/workerHost/textMateWorkerTokenizerController.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/services/textMate/browser/workerHost/textMateWorkerTokenizerController.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/services/textMate/browser/workerHost/textMateWorkerTokenizerController.ts
Outdated
Show resolved
Hide resolved
I need help with this one. I tried to understand how "vs/editor/common/services/editorSimpleWorker.ts" is bundled, but I wasn't able to figure it out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
Fixes #147066
Review #174364 first!
TODOs: