Adding keybindings for sticky scroll #174272
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…trol and alt and s
Tyriar
requested changes
Feb 13, 2023
src/vs/editor/contrib/stickyScroll/browser/stickyScrollActions.ts
Outdated
Show resolved
Hide resolved
| precondition: undefined, | ||
| keybinding: { | ||
| weight: KeybindingWeight.EditorContrib, | ||
| primary: KeyMod.Shift | KeyMod.CtrlCmd | KeyMod.Alt | KeyCode.KeyS, |
There was a problem hiding this comment.
That's a lot of modified and I associate S with saving, might be best to ask for opinions in #ux?
src/vs/editor/contrib/stickyScroll/browser/stickyScrollActions.ts
Outdated
Show resolved
Hide resolved
|
Thanks @Tyriar, I'll make this a draft pull request and bring it up in the UX sync this week :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding keybindings for sticky scroll. The keybindings chosen are: control + alt + shift + S. Fixes #169107.