Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow setting icon/color for tasks #151949

Merged
merged 12 commits into from
Jun 13, 2022
Merged

allow setting icon/color for tasks #151949

merged 12 commits into from
Jun 13, 2022

Conversation

meganrogge
Copy link
Contributor

This PR fixes #145965

@meganrogge meganrogge self-assigned this Jun 13, 2022
@meganrogge meganrogge marked this pull request as draft June 13, 2022 14:57
@vscodenpa vscodenpa added this to the June 2022 milestone Jun 13, 2022
jrieken
jrieken reviewed Jun 13, 2022
View reviewed changes
.vscode/tasks.json Outdated Show resolved Hide resolved
jrieken
jrieken previously requested changes Jun 13, 2022
View reviewed changes
src/vs/workbench/api/common/extHostTypes.ts Outdated Show resolved Hide resolved
ubaisa
ubaisa previously approved these changes Jun 13, 2022
View reviewed changes
meganrogge
meganrogge commented Jun 13, 2022
View reviewed changes
.vscode/tasks.json Outdated Show resolved Hide resolved
@meganrogge meganrogge marked this pull request as ready for review June 13, 2022 16:14
Tyriar
Tyriar approved these changes Jun 13, 2022
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like what I'd expect, @alexr00 might have better comments 🙂

@meganrogge meganrogge enabled auto-merge (squash) June 13, 2022 20:59
@meganrogge meganrogge merged commit c7a9cd2 into main Jun 13, 2022
@meganrogge meganrogge deleted the merogge/icon-task-color branch June 13, 2022 20:59
@github-actions github-actions bot locked and limited conversation to collaborators Jul 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexr00 alexr00 alexr00 left review comments

@ubaisa ubaisa ubaisa approved these changes

@Tyriar Tyriar Tyriar approved these changes

@jrieken jrieken Awaiting requested review from jrieken

Assignees

@meganrogge meganrogge

Labels
None yet
Projects
None yet
Milestone
June 2022
Development

Successfully merging this pull request may close these issues.

Set the color and icon of a task in the tasks.json
6 participants
@meganrogge @jrieken @Tyriar @alexr00 @ubaisa @vscodenpa