Git: Restore diff editors on reload

[yj7]

• VSCode Version: 1.45.1
• OS Version: Win 10

Steps to Reproduce:

1. Open a project with git configured
2. Open changes of a file using the source control section
3. Close VSCode
4. Relaunch VSCode

All other tabs will be opened except git diff changes tab

Does this issue occur when all extensions are disabled?: Yes

[alexdima]

Yes, +100 !!

[joaomoreno]

@bpasero What will it take for this to happen? This is a simple diff editor with a git document (from a custom file system) on the left side.

I also have a feeling we got this to work recently. 🤔

[bpasero]

@joaomoreno you need to register an editor input factory for anything you want to restore.

[joaomoreno]

I am (git is) an extension. Should I assign this to you or @alexdima?

[bpasero]

Oh wait. Ever since you adopted the file system provider API, the editor input factory is already there for you. However, we do not restore diff editors in general currently.

Is it safe to assume that a Git URL can simply be opened again in the future?

[joaomoreno]

Is it safe to assume that a Git URL can simply be opened again in the future?

Pretty safe!