Native Sierra-tabs are not working in macOS 10.12.x

[dalisoft]

• VSCode Version: V1.36.0 (1.36.0) and higher
• OS Version: macOS 10.12(.0-6)

Steps to Reproduce:

1. Download latest release
2. Try to use Sierra tab feature

Note: Insiders build already does not work on Sierra
Note 2: This feature works only for High Sierra and Mojave
Note 3: Can this feature be added to without OS specific? i.e. for Windows users and/or for El Capitan users?
Note 4: Upgrading to Mojave isn't solution as Mojave not available to all users

Does this issue occur when all extensions are disabled?: Yes

[bpasero]

@dalisoft are you saying that in VSCode 1.35 you could use native tabs on macOS Sierra (10.12.x) and now you need at least High Sierra (10.13.x) to use them?

[dalisoft]

@bpasero Only v1.35 worked for me (Sierra tab feature), before and last release works only in v10.13+ (old releases worked only 10.13+, i did not test latest release on 10.13+)

[bpasero]

@dalisoft that is weird, are you saying v1.34 also did NOT support native tabs on macOS Sierra 10.12.x?

We did an Electron update for 1.36, but I would be surprised if there is something that changed between 1.34 and 1.35 that could cause this.

[dalisoft]

Yes, v1.34 also did not worked. Insiders build also does not support native tabs, even it has fullscreen black space bug

[bpasero]

@dalisoft how exactly do you see that it is not working, does it partially work or not at all. Can you share your settings file?

[dalisoft]

It's not works at all

{
  "breadcrumbs.enabled": false,
  "extensions.autoUpdate": true,
  "telemetry.enableCrashReporter": false,
  "telemetry.enableTelemetry": false,
  "workbench.iconTheme": "material-icon-theme",
  "workbench.editor.highlightModifiedTabs": true,
  "workbench.editor.enablePreviewFromQuickOpen": false,
  "workbench.editor.enablePreview": false,
  "workbench.settings.enableNaturalLanguageSearch": false,
  "editor.wordWrap": "bounded",
  "editor.scrollBeyondLastLine": false,
  "editor.scrollBeyondLastColumn": 0,
  "editor.renderWhitespace": "all",
  "editor.cursorBlinking": "solid",
  "editor.cursorSmoothCaretAnimation": false,
  "editor.formatOnSave": true,
  "editor.formatOnPaste": false,
  "editor.formatOnType": false,
  "editor.minimap.enabled": false,
  "editor.minimap.renderCharacters": false,
  "editor.minimap.maxColumn": 200,
  "editor.minimap.showSlider": "always",
  "editor.defaultFormatter": "esbenp.prettier-vscode",
  "editor.fontFamily": "Monaco, Menlo, Consolas, 'Courier New', monospace",
  "editor.fontSize": 12,
  "editor.smoothScrolling": true,
  "editor.suggestSelection": "first",
  "editor.fontWeight": "100",
  "diffEditor.ignoreTrimWhitespace": false,
  "window.zoomLevel": 0,
  "window.title": "${dirty} ${activeEditorMedium}${separator}${rootName}",
  "window.nativeFullScreen": false,
  "window.nativeTabs": true,
  "javascript.validate.enable": false,
  "javascript.format.enable": false,
  "javascript.implicitProjectConfig.experimentalDecorators": true,
  "javascript.updateImportsOnFileMove.enabled": "always",
  "javascript.implicitProjectConfig.checkJs": true,
  "javascript.format.insertSpaceAfterSemicolonInForStatements": false,
  "javascript.suggest.autoImports": false,
  "typescript.validate.enable": false,
  "typescript.format.enable": false,
  "typescript.implementationsCodeLens.enabled": true,
  "typescript.referencesCodeLens.enabled": true,
  "typescript.updateImportsOnFileMove.enabled": "always",
  "css.validate": false,
  "less.validate": false,
  "scss.validate": false,
  "explorer.confirmDelete": false,
  "explorer.confirmDragAndDrop": false,
  "explorer.openEditors.visible": 0,
  "files.watcherExclude": {
    "**/.git/objects/**": true,
    "**/.git/subtree-cache/**": true,
    "**/node_modules/**": true,
    "**/dist/**": true,
    "**/build/**": true,
    "**/.cache/**": true,
    "**/.webpack/**": true
  },
  "files.autoSave": "onWindowChange",
  "files.trimTrailingWhitespace": true,
  "files.insertFinalNewline": true,
  "files.associations": {
    "*.js": "javascriptreact",
    "*.ts": "typescriptreact",
    "*.css": "postcss"
  },
  "eslint.autoFixOnSave": true,
  "eslint.runtime": "/usr/local/bin/node",
  "eslint.validate": [
    {
      "language": "vue",
      "autoFix": true
    },
    {
      "language": "javascript",
      "autoFix": true
    },
    {
      "language": "javascriptreact",
      "autoFix": true
    }
  ],
  "prettier.stylelintIntegration": true,
  "prettier.printWidth": 80,
  "prettier.jsxBracketSameLine": true,
  "prettier.arrowParens": "avoid",
  "prettier.eslintIntegration": true,
  "prettier.tslintIntegration": true,
  "prettier.requireConfig": false,
  "stylelint.enable": true,
  "emmet.includeLanguages": {
    "postcss": "css",
    "javascript": "javascriptreact"
  },
  "emmet.syntaxProfiles": {
    "postcss": "css"
  },
  "postcssSorting.config": {
    "order": [
      "custom-properties",
      "dollar-variables",
      "declarations",
      "at-rules",
      "rules"
    ],
    "properties-order": [
      "display",
      "position",
      "top",
      "right",
      "bottom",
      "left"
    ]
  },
  "sync.gist": "GIST_ID",
  "sync.autoUpload": false,
  "sync.autoDownload": false,
  "git.autofetch": true,
  "git.enableSmartCommit": true,
  "vsintellicode.modify.editor.suggestSelection": "automaticallyOverrodeDefaultValue",
  "terminal.explorerKind": "external",
  "terminal.integrated.shell.windows": "C:\\WINDOWS\\System32\\wsl.exe",
  // "terminal.integrated.shellArgs.windows": ["~"],
  "search.exclude": {
    "**/.cache": true,
    "**/.out": true,
    "**/build": true,
    "**/dist": true
  },
  "markdown.preview.fontFamily": "-apple-syLight BlinkMacSystemFont, 'Segoe WPC', 'Segoe UI', 'Ubuntu', 'Droid Sans', sans-serif",
  "workbench.editor.closeOnFileDelete": true,
  "workbench.colorTheme": "Oceanic Plus",
  "typescript.experimental.useSeparateSyntaxServer": true,
  "update.mode": "none",
  "update.enableWindowsBackgroundUpdates": false,
  "workbench.statusBar.feedback.visible": false
}

[bpasero]

@dalisoft ok I am sorry to hear that but I cannot tell why it fails for you :-(