Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git: Provide task progress #62751

Open
liguori opened this issue Nov 8, 2018 · 5 comments
Open

Git: Provide task progress #62751

liguori opened this issue Nov 8, 2018 · 5 comments
Assignees
Labels
feature-request Request for new features or functionality git GIT issues
Milestone

Comments

@liguori
Copy link
Member

liguori commented Nov 8, 2018

Request
It could be a nice feature to show the git progress details in the GIT output console or since Visual Studio even though is 'Code' has the characteristic to being 'Visual', polish the user interface with some indicator.
In the following images there are some suggestions:
progress 1
progress2

Use case
It happen sometime that users have in their own repository some big amount files or maybe the connection slow down during the 'git push', users don't have any idea what is happening or what is the current operation state (it could take even plenty of minutes).
In the example I'have done, this is what is showed actually in VS Code:
nothappen
And this is what it can be read from the git executable output:
expected

Advantages
Users that have this kind of experience can think that the git integration (that is already amazing in VS Code) is not working very good because the operations appears 'blocked'. So they give up and jump on the CLI for the daily usage of git. With some nice improvements like I showed they wouldn't do it.

Technical inspection
I inspected the main source code file about the default GIT extension:
https://github.com/Microsoft/vscode/blob/master/extensions/git/src/git.ts
A nice implementation could be extract more information on the 'git commands output' parsing, ex. Operation 'N' of 'M' and 'Percentage', expose it and use on higher layer of Visual Studio Code.

Waiting for a your feedback.

Thank you.

@vscodebot vscodebot bot added the git GIT issues label Nov 8, 2018
@XVincentX
Copy link
Member

My two cents:

  1. The percentages shown in the command line are merely about Compression and Writing objects. There's no way to track the push operation itself (uploads included).
  2. Git supports hook (in particular pre-push and post-push and all the good stuff around) — they're generic commands that can't be tracked in any way (as you have no idea what's being executed).

So while it is possible to provide a certain degree of the operation progress, there are different unknown parts which are effectively untraceable. That percentages are only a part of the push process.

@liguori
Copy link
Member Author

liguori commented Nov 8, 2018

As basic implementation It could be enough to handle the git 'stdinfo' outoput and show it inside the git output console (maybe optionally with some "show git verbose output" flag in the settings).
As plus this output could be parsed and shown in a label (without a real progress bar) giving to the user a sense of 'real processing'.

@joaomoreno joaomoreno added this to the Backlog milestone Nov 13, 2018
@joaomoreno joaomoreno added the feature-request Request for new features or functionality label Nov 13, 2018
@joaomoreno joaomoreno removed their assignment Nov 13, 2018
@joaomoreno joaomoreno changed the title Feature Request - Provide progress indicator for GIT operations Git: Provide task progress Nov 13, 2018
@mugglmenzel
Copy link

+1
the "writing objects" line actually indicates network transfer. observed it with slow wifis 😄

@ggedde
Copy link

ggedde commented Nov 28, 2019

I am not sure if I think a progress can been done correctly as the remote may be doing much more then normal git commands, but I do think there should be some sort of way to see the raw output from the remote which there doesn't seem to be unless your run all your git commands from the Terminal which I would prefer not to.

I created a separate issue for that: #85732

@joaomoreno joaomoreno removed their assignment Nov 11, 2020
@lszomoru lszomoru self-assigned this Oct 4, 2021
@alumni
Copy link

alumni commented Oct 29, 2021

The issue description did not mention hook progress explicitly, but git hooks can take more time than the actual git operation, and the hook progress is not visible.

GUIs like GitExtensions would show a dialog with the progress of the entire operation, including the hooks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality git GIT issues
Projects
None yet
Development

No branches or pull requests

7 participants