Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[folding] "Select all Occurrences" bug #41538

Open
mhchem opened this issue Jan 12, 2018 · 1 comment
Open

[folding] "Select all Occurrences" bug #41538

mhchem opened this issue Jan 12, 2018 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug editor-folding Editor code folding issues
Milestone

Comments

@mhchem
Copy link

mhchem commented Jan 12, 2018

  • VSCode Version: 1.19.2
  • OS Version: Win 10

Steps to Reproduce:

  • Open a new document and paste the following content
abc
  abc
  def
  ghi

abc
  abc
  def
  ghi
  • Place the cursor in the first line and execute Fold (Ctrl + Shift + [)
  • Select "abc" in the 3rd line
  • Select all occurrences (Ctrl + Shift + L)
  • type A to replace all selections with "A"
  • Unfold All (Ctrl + K Ctrl + J)
  • There are 3 A's in the document. Expected: 4.
@aeschli aeschli self-assigned this Jan 15, 2018
@aeschli aeschli added the editor-folding Editor code folding issues label Mar 1, 2018
@aeschli aeschli added this to the March 2018 milestone Mar 1, 2018
@aeschli aeschli added the bug Issue identified by VS Code Team member as probable bug label Mar 1, 2018
@aeschli aeschli modified the milestones: March 2018, April 2018 Mar 27, 2018
@aeschli aeschli changed the title Folding and "Select all Occurrences" bug [folding] "Select all Occurrences" bug Apr 18, 2018
@aeschli aeschli modified the milestones: April 2018, May 2018 Apr 18, 2018
@aeschli aeschli modified the milestones: May 2018, June 2018 May 29, 2018
@aeschli aeschli modified the milestones: June 2018, July 2018 Jun 27, 2018
@aeschli aeschli modified the milestones: July 2018, Backlog Jul 30, 2018
@latere-a-latere
Copy link

I just checked this bug in the latest stable release, 1.73.1, and it appears to have been fixed some time ago. I performed the following steps:

  1. ctrl+n new file
  2. Set language to plaintext
  3. Pasted OP's example
  4. Moved cursor to 1:1
  5. Executed 'Fold'
  6. Moved cursor to 6:1
  7. Selected 6:1 to 6:3 ('abc')
  8. Executed 'Select all occurences'
  9. Typed A
  10. Executed 'Unfold all' (this did nothing because everything was already unfolded)

It appears that 'Select all occurences' also performs an unfold which selects the folded in 'abc'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug editor-folding Editor code folding issues
Projects
None yet
Development

No branches or pull requests

3 participants