Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buttons with Insufficiently Descriptive Accessible Names #227519

Open
Bluefish0558 opened this issue Sep 4, 2024 · 3 comments
Open

Buttons with Insufficiently Descriptive Accessible Names #227519

Bluefish0558 opened this issue Sep 4, 2024 · 3 comments
Assignees
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues feature-request Request for new features or functionality under-discussion Issue is under discussion for relevance, priority, approach

Comments

@Bluefish0558
Copy link

Does this issue occur when all extensions are disabled?: Yes/No

  • VS Code Version: 1.92.2
  • OS Version: 14.6.1 (23G93)

Description: Certain buttons, such as the "More actions" gear icon, have insufficiently descriptive accessible names, making it difficult for screen reader users to understand their purpose.

Steps to Reproduce:

  1. Navigate to the "More actions" button (gear icon) in VSCode.
  2. Use a screen reader to interact with the button and notice that the accessible name is not descriptive enough.

User Impact: Screen reader users are unable to determine the purpose of these buttons due to the lack of descriptive accessible names.

Expected Behavior: Buttons should have clear and descriptive accessible names, using internal text, aria-label, or aria-labelledby. For example, the "More actions" button could be labeled as "More Actions for Inline Code Suggestions (Shift+F9)."

Actual Behavior: The button has a generic name that does not provide enough context, limiting its accessibility.

Recommendation: Ensure all buttons have descriptive and concise accessible names that provide clear context. Avoid including the word "button" in the name, as the role is already indicated by the button element.

settingss
@meganrogge meganrogge added bug Issue identified by VS Code Team member as probable bug accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues labels Sep 6, 2024
@meganrogge
Copy link
Contributor

I'm on the fence here, as the user knows the context in which their button exists since they've navigated to that area. Thoughts @isidorn ?

@meganrogge meganrogge added the under-discussion Issue is under discussion for relevance, priority, approach label Sep 6, 2024
@isidorn
Copy link
Contributor

isidorn commented Sep 9, 2024

Agreed with you @meganrogge, I would expect the user to know the context.
Having longer names will make the experience more verbose (which users always dislike).

I suggest to keep this open as a feature request to gather more user feedback.

@meganrogge meganrogge added feature-request Request for new features or functionality and removed bug Issue identified by VS Code Team member as probable bug labels Sep 9, 2024
@vs-code-engineering vs-code-engineering bot added this to the Backlog Candidates milestone Sep 9, 2024
Copy link

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues feature-request Request for new features or functionality under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Development

No branches or pull requests

3 participants