Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The empty editor hint should be easily toggled by right clicking on the hint #213814

Open
Tyriar opened this issue May 29, 2024 · 7 comments · Fixed by #214185 or #218548
Open

The empty editor hint should be easily toggled by right clicking on the hint #213814

Tyriar opened this issue May 29, 2024 · 7 comments · Fixed by #214185 or #218548
Assignees
Labels
feature-request Request for new features or functionality verification-needed Verification of issue is requested
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented May 29, 2024

Can this support right click to toggle the setting to hidden?

image

@joyceerhl joyceerhl added the feature-request Request for new features or functionality label May 29, 2024
@joyceerhl joyceerhl added this to the June 2024 milestone May 29, 2024
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jun 3, 2024
@Yoyokrazy Yoyokrazy added the verification-needed Verification of issue is requested label Jun 25, 2024
@jrieken jrieken added the verification-found Issue verification failed label Jun 25, 2024
@jrieken jrieken reopened this Jun 25, 2024
@VSCodeTriageBot VSCodeTriageBot removed the insiders-released Patch has been released in VS Code Insiders label Jun 25, 2024
@jrieken
Copy link
Member

jrieken commented Jun 25, 2024

Re-opening because I believe just right clicking to disable isn't a great nor established gesture.

I am all in for configurability but right clicking should show a context menu with a toggle so that I know what's happening. We support a similar flow for breadcrumbs, sticky scroll, minimap etc

@jrieken
Copy link
Member

jrieken commented Jun 25, 2024

Terminals have this

Screenshot 2024-06-25 at 14 32 57

@Tyriar
Copy link
Member Author

Tyriar commented Jun 25, 2024

I should have described it better, I meant for it to be in a context menu as otherwise it's too easy to permanently dismiss accidentally

@joyceerhl joyceerhl removed the verification-found Issue verification failed label Jun 26, 2024
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jun 26, 2024
@bpasero
Copy link
Member

bpasero commented Jun 27, 2024

I would align this with the hint we already have for empty editors:

Image

Specifically there is an explicit link to "Do not show again" which is easily discoverable.

@bpasero bpasero reopened this Jun 27, 2024
@VSCodeTriageBot VSCodeTriageBot removed the insiders-released Patch has been released in VS Code Insiders label Jun 27, 2024
@bpasero bpasero added the verification-found Issue verification failed label Jun 27, 2024
@Tyriar
Copy link
Member Author

Tyriar commented Jun 27, 2024

I commented the other day in standup how noisy that message has become, if anything we should be reducing the size of that message. Especially if when we install Copilot it's no longer important enough to show at all. In the same vein we're trying to keep the terminal message as small as possible. @daviddossett could you weigh in here?

@jrieken
Copy link
Member

jrieken commented Jun 27, 2024

I agree but having the full "Start typing to dismiss or don't show this again" message doesn't seem so bad. We already have the first half and with copilot installed it is much shorter than the default message

@bpasero
Copy link
Member

bpasero commented Jun 27, 2024

To clarify: all I am suggesting is to:

  • not have a context menu
  • add or don't show this again to the current copilot message

@joyceerhl joyceerhl removed this from the June 2024 milestone Jun 27, 2024
@joyceerhl joyceerhl added this to the July 2024 milestone Jun 27, 2024
@joyceerhl joyceerhl removed the verification-found Issue verification failed label Jun 27, 2024
@joyceerhl joyceerhl modified the milestones: July 2024, August 2024 Jul 25, 2024
@joyceerhl joyceerhl modified the milestones: August 2024, September 2024 Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality verification-needed Verification of issue is requested
Projects
None yet
7 participants