Terminal tab change icon does not work with multi-select

Repro:

- Open multiple terminals
- Select multiple terminal tabs
- Right click and change icon
- Change icon 🐛 only a single terminal is changed

https://github.com/microsoft/vscode/blob/d878a801801af60a91b8b50c16032386f40bdcc3/src/vs/workbench/contrib/terminal/browser/terminalActions.ts#L708-L714

Real context stored with the action was done recently as part of https://github.com/microsoft/vscode/issues/79034

Related: https://github.com/microsoft/vscode/issues/193379

	registerTerminalAction({
	id: TerminalCommandId.ChangeIconActiveTab,
	title: terminalStrings.changeIcon,
	f1: false,
	precondition: ContextKeyExpr.and(ContextKeyExpr.or(TerminalContextKeys.processSupported, TerminalContextKeys.terminalHasBeenCreated), TerminalContextKeys.tabsSingularSelection),
	run: (c, accessor) => getSelectedInstances(accessor)?.[0].changeIcon()
	});

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Terminal tab change icon does not work with multi-select #193378

Tyriar
openedon Sep 18, 2023

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Terminal tab change icon does not work with multi-select #193378

Description

Tyriaropenedon Sep 18, 2023

Metadata