Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PowerShell terminal is displaying dark colors as bright colors #192640

Open
SetTrend opened this issue Sep 8, 2023 · 3 comments
Open

PowerShell terminal is displaying dark colors as bright colors #192640

SetTrend opened this issue Sep 8, 2023 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues themes Color theme issues
Milestone

Comments

@SetTrend
Copy link

SetTrend commented Sep 8, 2023

Even though I set the minimum contrast ratio to "1", PowerShell terminal is displaying dark colors as bright colors:

No dark colors PowerShell

VS Code/OS Version:

Version: 1.82.0 (user setup)
Commit: 8b617bd08fd9e3fc94d14adb8d358b56e3f72314
Datum: 2023-09-06T22:07:07.438Z
Electron: 25.8.0
ElectronBuildId: 23503258
Chromium: 114.0.5735.289
Node.js: 18.15.0
V8: 11.4.183.29-electron.0
Betriebssystem: Windows_NT x64 10.0.19045

Steps to Reproduce:

  1. Type
    Write-Host -ForegroundColor Yellow 'Test'
  2. Type
    Write-Host -ForegroundColor DarkYellow 'Test'
@Tyriar
Copy link
Member

Tyriar commented Sep 11, 2023

This is working as designed because it's up to the theme to control these colors:

image

@daviddossett a slight differentiation of these colors would be nice in the new modern themes

@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug themes Color theme issues terminal Integrated terminal issues labels Sep 11, 2023
@Tyriar Tyriar added this to the Backlog milestone Sep 11, 2023
@SetTrend
Copy link
Author

Thank you.

This is particularly necessary to test and verify the output of a PowerShell script that's supposed to be published.

Without these dimmed colors, it is impossible to highlight portions of a text, and the setting terminal.integrated.drawBoldTextInBrightColors doesn't make sense.

@Tyriar
Copy link
Member

Tyriar commented Sep 21, 2023

@SetTrend VS Code supports it fine, just the default themes don't. So in the meantime you should change your theme to one that has different colors for the bright colors, or set them manually via the workbench.colorCustomizations setting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues themes Color theme issues
Projects
None yet
Development

No branches or pull requests

4 participants