Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[themes] mark favorites themes #188989

Open
kirellkekw opened this issue Jul 26, 2023 · 5 comments
Open

[themes] mark favorites themes #188989

kirellkekw opened this issue Jul 26, 2023 · 5 comments
Assignees
Labels
feature-request Request for new features or functionality themes Color theme issues
Milestone

Comments

@kirellkekw
Copy link

kirellkekw commented Jul 26, 2023

There is only three classes of color themes, dark, light and high contrast. It would be great to have an option to create a custom class such as "Favorites" with ones we choose, showing on top or in the order we set.
For example, a custom class with
Dark Modern,
Community Material Theme Darker High Contrast,
Material Theme Darker High Contrast
under the name of "Dark Themes" would be great.
settings.json config parameters can be set as follows:
"""
colorTheme.customClasses = [
{"Dark Themes": [
"Dark Modern",
"Community Material Theme Darker High Contrast",
"Material Theme Darker High Contrast",
]
]
"""
Thanks for your time and patience to read through this request.

@kirellkekw kirellkekw reopened this Jul 28, 2023
@aeschli aeschli changed the title Allow creating custom classes of color themes [themes] mark favorites themes Aug 18, 2023
@aeschli aeschli added themes Color theme issues feature-request Request for new features or functionality labels Aug 18, 2023
@VSCodeTriageBot VSCodeTriageBot added this to the Backlog Candidates milestone Aug 18, 2023
@VSCodeTriageBot
Copy link
Collaborator

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@aeschli
Copy link
Contributor

aeschli commented Aug 18, 2023

Having favorites makes sense. I'm not sure about the need for custom categories. Tricky how to merge the current categories with the custom ones and there would be quite some work to get good configuration UI (creating new categories, assigning themes to categories).
I hope you are fine that I changed the request description to adding support of favorites. If not, please change it back.

@kirellkekw
Copy link
Author

Thanks for clarifying the description. Having favorites can make it easier swap and even having a sort of "playlist" that allows automatically changing themes on launch/on time period etc.

@VSCodeTriageBot
Copy link
Collaborator

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@VSCodeTriageBot
Copy link
Collaborator

🙂 This feature request received a sufficient number of community upvotes and we moved it to our backlog. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality themes Color theme issues
Projects
None yet
Development

No branches or pull requests

3 participants