Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt onWillSaveNotebook into notebookAttachmentCleaner.ts #179211

Closed
Yoyokrazy opened this issue Apr 4, 2023 · 0 comments · Fixed by #179178
Closed

Adopt onWillSaveNotebook into notebookAttachmentCleaner.ts #179211

Yoyokrazy opened this issue Apr 4, 2023 · 0 comments · Fixed by #179178
Assignees
@Yoyokrazy
Labels
insiders-released Patch has been released in VS Code Insiders notebook-markdown on-testplan
Milestone
April 2023

Comments

@Yoyokrazy
Copy link
Contributor

Use newly created onWillSaveNotebook api to fix corner cases within the notebook attachment cleaner.

User could potentially edit and save quickly, causing a dirty notebook immediately following saving.
@Yoyokrazy Yoyokrazy self-assigned this Apr 4, 2023
@Yoyokrazy Yoyokrazy transferred this issue from microsoft/vscode-jupyter Apr 4, 2023
@Yoyokrazy Yoyokrazy mentioned this issue Apr 4, 2023
Merged
@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label Apr 5, 2023
@VSCodeTriageBot VSCodeTriageBot added this to the April 2023 milestone Apr 5, 2023
@kieferrm kieferrm mentioned this issue Apr 6, 2023
Closed
16 tasks
@VSCodeTriageBot VSCodeTriageBot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Apr 6, 2023
@Yoyokrazy Yoyokrazy mentioned this issue Apr 24, 2023
Closed
3 tasks
@github-actions github-actions bot locked and limited conversation to collaborators May 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Yoyokrazy Yoyokrazy

Labels
insiders-released Patch has been released in VS Code Insiders notebook-markdown on-testplan
Projects
None yet
Milestone
April 2023
Development

Successfully merging a pull request may close this issue.

Add support for attachment cleaning on notebook save microsoft/vscode
2 participants
@Yoyokrazy @VSCodeTriageBot