Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focus sticky scroll is not preserved when sticky lines disappear and reapper #177770

Closed
dbaeumer opened this issue Mar 21, 2023 · 4 comments · Fixed by #177813
Closed

Focus sticky scroll is not preserved when sticky lines disappear and reapper #177770

dbaeumer opened this issue Mar 21, 2023 · 4 comments · Fixed by #177813
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug editor-sticky-scroll insiders-released Patch has been released in VS Code Insiders verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@dbaeumer
Copy link
Member

Testing #177642

  • have a couple of lines in sticky scroll
  • Focus sticky scroll
  • scroll inside the file to a place that sticky scroll lines disappear
  • scroll to a place that has sticky scroll lines again

Observe: focus is lost. I would have expected that focus is kept.

@dbaeumer
Copy link
Member Author

Closing the issue since this is actually by design. Still I would have expected otherwise.

@dbaeumer
Copy link
Member Author

I am actually reopening it since I think the behavior is not good when scrolling using the scroll bar / minimap

@dbaeumer dbaeumer reopened this Mar 21, 2023
@dbaeumer
Copy link
Member Author

Do the following:

  • focus sticky scroll
  • use the minimap to scroll to the top of the file whithout releasing the mouse
  • Observe: sticky scroll disappears and focus is gone
  • Scroll into the file again
  • Observe: sticky scroll apprears without focus.

I would have expected in this case that the focus is preserved since I never released the mouse button.

@aiday-mar aiday-mar added editor-sticky-scroll bug Issue identified by VS Code Team member as probable bug labels Mar 21, 2023
@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label Mar 21, 2023
@VSCodeTriageBot VSCodeTriageBot added this to the March 2023 milestone Mar 21, 2023
@aiday-mar aiday-mar added the verification-needed Verification of issue is requested label Mar 21, 2023
@VSCodeTriageBot VSCodeTriageBot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Mar 22, 2023
@aiday-mar
Copy link
Contributor

aiday-mar commented Mar 22, 2023

For the person who will be doing the verification, a regression has been found relating to the incorrect focusing of the sticky scroll which has already been fixed in the following PR: #178009. You may track its release through the corresponding issue: #177874. Please test once the other PR is released on insiders. In the meantime the label unreleased will be added. Alternatively test on Code OSS.

@aiday-mar aiday-mar added the unreleased Patch has not yet been released in VS Code Insiders label Mar 22, 2023
@VSCodeTriageBot VSCodeTriageBot removed the unreleased Patch has not yet been released in VS Code Insiders label Mar 23, 2023
@dbaeumer dbaeumer added the verified Verification succeeded label Mar 23, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug editor-sticky-scroll insiders-released Patch has been released in VS Code Insiders verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants