Closed
Description
openedon Mar 17, 2023
Refs: #175676
- Windows @amunger
- macOS @ulugbekna
- Linux @rzhao271 @andreamah
Complexity: 4
This milestone, we've integrated sharing links into additional entrypoints in our product surface area.
Setup:
- Install the pre-release of GitHub Pull Requests and Issues
- Install the pre-release of GitHub Repositories and Azure Repos
- Install the VS Code selfhost test provider
Testing:
- Right click on both the editor line number and gutter to bring up the context menu and verify that it contains the following entries:
Editor | Entries |
---|---|
A JSON or Markdown file in a cloned repo | Copy vscode.dev and GitHub Link actions |
A TypeScript or Python file in a cloned repo | Debug and Copy vscode.dev and GitHub actions |
Any notebook file (ipynb or github-issues) in a cloned repo | Debug and Copy vscode.dev actions |
A TypeScript file in the microsoft/vscode repo containing tests in a cloned repo |
Debug, Test, and Copy vscode.dev and GitHub actions |
Any text file in a GitHub repo on vscode.dev | Copy vscode.dev and GitHub link actions |
Any notebook file (ipynb or github-issues) in a GitHub repo on vscode.dev | Copy vscode.dev and GitHub link actions |
Any text file in an Azure Repos repo on vscode.dev | Copy vscode.dev link action |
Any notebook file (ipynb or github-issues) in an Azure Repos repo on vscode.dev | Copy vscode.dev link action |
- (macOS only): verify that ctrl+click behaves the same as right click
- Verify that the context menu does not interfere with your ability to use debug breakpoints or testing decorations
- Verify that you can use the copy _ link commands to generate links for a specific line and for a ranged selection from the editor gutter context menu, and that the ranges behave as expected
- Verify that the Copy GitHub link actions always generate github.com links even on vscode.dev, and the Copy vscode.dev link actions always generate vscode.dev links
- Verify that opening the copied links in vscode.dev or github.com works as expected
- vscode.dev links generated for notebooks should deeplink to a specific notebook cell and line
- Repeat for the following newly added share submenus:
- editor title context share submenu
- explorer context share submenu
- Open the GitHub Pull Requests and Issues view. Verify that there is a new option to checkout a PR on vscode.dev (in addition to the existing option to checkout the PR locally), and that it behaves as expected
- Do some exploratory testing and make a note of any places where you would expect to find a share link but did not find one
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment