Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the Interactive Editor model conform more closely with FileWorkingCopies #172974

Closed
amunger opened this issue Jan 31, 2023 · 2 comments
Closed
Assignees

Comments

@amunger
Copy link
Contributor

amunger commented Jan 31, 2023

after the change to use the simpleNotebookEditorModel #171283, we had to implement some workarounds to avoid the backup service recovering or asking to save Interactive Windows since we've been treating them more as throw-away resources. We should try to integrate better with the working copy service to make use of the functionality provided.

One way to do this is using an untitled resource, so that it wouldn't rely on the dummy file service we created and also wouldn't auto-save. We would also want a setting to close and discard IW resources without confirmation, which may need to be implemented in the backup service.

work-arounds for the current implementation:
#172595
#172427

@amunger amunger added debt Code quality issues interactive-window labels Jan 31, 2023
@amunger amunger self-assigned this Jan 31, 2023
@amunger
Copy link
Contributor Author

amunger commented Feb 15, 2023

for the confirmation on editor close, EditorInput can fully override that:

/**
* Optional: subclasses can override to implement
* custom confirmation on close behavior.
*/
readonly closeHandler?: IEditorCloseHandler;

@amunger
Copy link
Contributor Author

amunger commented Jun 26, 2023

completed in #184757

@amunger amunger closed this as completed Jun 26, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Aug 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant