Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Truncated lines are not obvious in the text editor #162320

Closed
kieferrm opened this issue Sep 28, 2022 · 1 comment · Fixed by #164331
Closed

Truncated lines are not obvious in the text editor #162320

kieferrm opened this issue Sep 28, 2022 · 1 comment · Fixed by #164331
Assignees
@alexdima
Labels
editor-rendering Editor rendering issues feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan
Milestone
October 2022

Comments

@kieferrm
Copy link
Member

Testing microsoft/vscode-jupyter#11463, I (re)learned today that we truncate long lines.

My setup:

  1. Open insiders.vscode.dev
  2. Install Jupyter and Python extensions
  3. Create a new untitled jupyter notebook
  4. Create a markdown cell
  5. Paste image
  6. Save notebook
  7. Reopen notebook with text editor
  8. Switch off line wrapping
  9. Search for character sequence is in the text editor

-> At some point you reach the end of the truncated line without being aware what's happening. It feels like the editor stops responding. See recording here: https://share.cleanshot.com/g4qxRZ

When I checkout the warning about tokenization and look at the setting, I don't learn that the line is truncated.
@alexdima alexdima transferred this issue from microsoft/vscode-jupyter Sep 29, 2022
@alexdima alexdima added this to the October 2022 milestone Sep 29, 2022
@alexdima
Copy link
Member

Tracking this in #7772

@alexdima alexdima added editor-rendering Editor rendering issues feature-request Request for new features or functionality labels Sep 29, 2022
@alexdima alexdima removed this from the October 2022 milestone Sep 29, 2022
@alexdima alexdima added this to the October 2022 milestone Oct 10, 2022
@kieferrm kieferrm mentioned this issue Oct 10, 2022
Closed
77 tasks
@alexdima alexdima mentioned this issue Oct 22, 2022
Merged
alexdima added a commit that referenced this issue Oct 22, 2022
@alexdima
Fixes #162320: Add a button and a hover when a long line is truncated
d865f72
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Oct 23, 2022
@alexdima alexdima mentioned this issue Oct 24, 2022
Closed
2 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Dec 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexdima alexdima

Labels
editor-rendering Editor rendering issues feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan
Projects
None yet
Milestone
October 2022
Development

Successfully merging a pull request may close this issue.

Add a button and a hover when a long line is truncated microsoft/vscode
3 participants
@kieferrm @alexdima @VSCodeTriageBot