selection highlight no longer shown in scrollbar ("overview ruler")

[conceptualspace]

• VSCode Version: 1.7.2
• OS Version: replicated on Win 10 x64 and OSX 10.11.6

when editing a *.js file, selecting a string (ex by double clicking it) no longer shows the matched strings in the scrollbar.

oddly, if i select a string and then restart vscode, the highlights do appear

see also issue #2998, which describes the same problem (was fixed but seems to have broken again)

[conceptualspace]

seems to be affecting javascript source files (*.js) -- have not observed it in other file types

[conceptualspace]

running a regular find also shows the matches correctly

[rebornix]

For JavaScript and TypeScript files, document highlights are provided by TypeScript extension. However TypeScript ext is not providing correct word highlight items sometimes. Take a gulp file as example,

// Fast compile for development time
gulp.task('clean-client', util.rimraf('out'));
gulp.task('compile-client', ['clean-client'], compilation.compileTask('out', false));
gulp.task('watch-client', ['clean-client'], compilation.watchTask('out', false));

You can see correct decorations on the scroll bar when selecting gulp while you can't see anything if you select task. For TypeScript files, I can't reproduce this.

[MikeyBurkman]

Has there been any progress on this? It's really annoying trying to work on angular code now, since I can no longer double click on "foo" in vm.foo and see all occurrences of the variable.

[dbaeumer]

@conceptualspace I am a little bit puzzled. The screen shot you show is a plain text file so no JS.

@rebornix for JS to work correctly typings have to be installed using ATA which depends on a 'correct' package.json. Here is what I see:

@mjbvz can you please investigate.

@MikeyBurkman do you have an small example to reproduce this.

[alexdima]

just a note on the editor selection highlights:

• if a file has an occurences provider, the selection highlights don't show up in the overview ruler (i.e. to not "fight" with the ones coming in from the occurences provider - wordHighlighter).
• if a file does not have an occurences provider, the selection highlights show up in the overview ruler.

[MikeyBurkman]

@dbaeumer The highlighting in the editor window works as expected. However, even though things appear highlighted in the editor, they do not show up in the scrollbar to the right.

You actually see the same behavior in TS as well as JS, if the type of the variable is any. This makes sense, as the type of most variables in JS are assumed by the editor to be any.

// Typescript
let myVar: any = {
  foo: 20
};
...
myVar.foo = 58;

If you double-click on myVar, you'll see myVar highlighted in both places in the editor, as well as seeing two occurrences in the scroll bar. However, if you double click on foo, you'll still see it highlighted both times in the editor, but you'll only see one occurrence in the scroll bar, in the exact location that is selected.

In that code snippet, if you remove the any type for myVar, and let type inference do its magic, then double-clicking foo will show two occurrences in the scrollbar, which is what you'd expect. This is true of both JS and TS files.

In a nutshell, the scrollbar highlighting only appears for occurrences that the editor is sure are matches. However, if the type is any, which it almost always is in JS files, then the scrollbar highlighting doesn't show anything, and this is not terribly useful behavior for JS.

[conceptualspace]

@dbaeumer I simply grabbed the screenshot from the previous issue (#2998); be assured you can replicate against a js file

[mjbvz]

@alexandrudima It sounds like the current behavior is expected because TS has an occurrences provider. Is there an way to fall back to the old selection highlight behavior if we don't find any occurrences using our occurrences provider? Besides the any issues noted, there are lots of places in TS files where our occurrences provide fails, such as for occurrences of type declaration types themselves.