Skip to content

Merge editor and auto save #152841

Closed
Closed

Description

(wasn't sure if we already had an issue for this)

In my mind, the merge editor should not auto save but stay dirty even when auto save is enabled. Especially since it opens dirty right when you click it, auto save fires right after.

Question is: should auto save still be supported if all conflicts are resolved? Maybe that would be a nice model:

  • until there are conflicts, auto save ignores the editor
  • once all conflicts are resolved, auto save kicks in

I think there is missing working copy support for this because currently auto save is driven by a capability:

if (editorIdentifier?.editor.hasCapability(EditorInputCapabilities.Readonly) || editorIdentifier?.editor.hasCapability(EditorInputCapabilities.Untitled)) {
return; // no auto save for readonly or untitled editors
}

We could introduce a new capability CanAutoSave. But unsure how to wire this through because currently the merge editor uses the same text file model working copy as a normal editor.

Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Labels

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions