Skip to content

Delete commands (deleteLeft, deleteRight) don't work in dialogs #147218

Open

Description

Issue Type: Bug

Steps to reproduce

  1. Add the following to keybindings.json
{
        "key": "ctrl+h",
        "command": "deleteLeft"
},
  1. Verify it works in file focus

  2. Execute it in a dialog focus (find or command palette) and get unexpected result

Expectation: A character from the focused dialog should be deleted
Actuality: A character from the last editor focus is deleted

When I search the binding for my backspace key in Preferences: Open Keyboard Shortcuts, it shows that backspace is bound to deleteLeft. The aforementioned result is all the more unexpected considering that the backspace key does what I expect whereas ctrl+h doesn't, even though they are "supposedly" bound to the same command.

VS Code version: Code 1.66.1 (8dfae7a, 2022-04-06T14:50:12.141Z)
OS version: Windows_NT x64 10.0.22000
Restricted Mode: No

System Info
Item Value
CPUs 11th Gen Intel(R) Core(TM) i7-1185G7 @ 3.00GHz (8 x 2995)
GPU Status 2d_canvas: enabled
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
oop_rasterization: enabled
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_renderer: enabled_on
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
Load (avg) undefined
Memory (System) 15.71GB (5.82GB free)
Process Argv --crash-reporter-id b6b63ffd-30a1-4a6a-ad59-7dbdd7de2c9f
Screen Reader no
VM 0%
Extensions (39)
Extension Author (truncated) Version
project-manager ale 12.5.0
tsl-problem-matcher amo 0.6.2
github-markdown-preview bie 0.2.0
markdown-checkbox bie 0.3.2
markdown-emoji bie 0.2.1
markdown-footnotes bie 0.0.7
markdown-preview-github-styles bie 1.0.1
markdown-yaml-preamble bie 0.1.0
gitignore cod 0.7.0
doxdocgen csc 1.4.0
vscode-eslint dba 2.2.2
git-extension-pack don 0.1.3
githistory don 0.6.19
gitlens eam 12.0.5
EditorConfig Edi 0.16.4
go gol 0.32.0
better-cpp-syntax jef 1.15.13
Lisp mat 0.1.12
vscode-docker ms- 1.21.0
python ms- 2022.4.1
vscode-pylance ms- 2022.4.0
jupyter ms- 2022.3.1000901801
jupyter-keymap ms- 1.0.0
jupyter-renderers ms- 1.0.6
remote-containers ms- 0.231.5
remote-ssh ms- 0.78.0
remote-ssh-edit ms- 0.80.0
remote-wsl ms- 0.66.0
cmake-tools ms- 1.10.5
cpptools ms- 1.9.7
cpptools-extension-pack ms- 1.1.0
powershell ms- 2021.12.0
multi-command ryu 1.5.1
kb-macro tsh 0.12.0
cmake twx 0.0.17
groog und 0.0.1
clang-format xav 1.9.0
vscode-open-in-github ziy 1.3.6
vscode-proto3 zxh 0.5.5

(1 theme extensions excluded)

A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vstes627:30244334
pythonvspyl392:30443607
pythontb:30283811
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
pythondataviewer:30285071
vscod805:30301674
pythonvspyt200:30340761
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593:30376534
vsc1dst:30438360
pythonvs932:30410667
wslgetstarted:30449410
pythonvsnew555:30457759
vscscmwlcmt:30465135
cppdebugcf:30466690
pynewfile477:30463512

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    editor-commandsEditor text manipulation commandsfeature-requestRequest for new features or functionality

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions