Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal Find up and down arrows appeared enabled even if no matches #145807

Closed
gregvanl opened this issue Mar 22, 2022 · 5 comments · Fixed by #146358
Closed

Terminal Find up and down arrows appeared enabled even if no matches #145807

gregvanl opened this issue Mar 22, 2022 · 5 comments · Fixed by #146358
Assignees
@Tyriar @meganrogge
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-find Relating the terminal's find widget verified Verification succeeded
Milestone
April 2022

Comments

@gregvanl
Copy link

Testing #145629

  1. Create a terminal and open the Find widget.
  2. Type some text that doesn't have any matches

The up and down navigation arrows are bright and look enabled even though there are no locations to navigate to.

image
@meganrogge meganrogge added bug Issue identified by VS Code Team member as probable bug terminal-find Relating the terminal's find widget labels Mar 23, 2022
@meganrogge meganrogge added this to the Backlog milestone Mar 23, 2022
@Tyriar
Copy link
Member

Tyriar commented Mar 23, 2022

This needs #134791 first. Assigning to April to see if we can get it done with that issue.

@Tyriar Tyriar modified the milestones: Backlog, April 2022 Mar 23, 2022
This was referenced Mar 28, 2022
Closed
Merged
@rzhao271 rzhao271 added the verified Verification succeeded label Apr 27, 2022
@rzhao271
Copy link
Contributor

rzhao271 commented Apr 27, 2022 •
edited
Loading

There is still a bit of a difference between the terminal find widget and the editor find widget when there are no find results.

  1. When pressing down on the arrows in the terminal find widget, the arrows darken. When pressing down on the arrows in the editor find widget, the arrows continue to have the disabled/greyed-out look.
  2. The arrow buttons in the editor find widget appear rounded whereas the ones on the terminal find widget do not.

A screencap demonstrating the points above

@meganrogge
Copy link
Contributor

@rzhao271 yep the style inconsistencies will be fixed by this #148306

@meganrogge
Copy link
Contributor

I do see that the button focus border still won't be rounded though and the arrows shouldn't be dark when clicked. Looking into it now

@meganrogge
Copy link
Contributor

fixed those too f72ab1b thanks @rzhao271

@github-actions github-actions bot locked and limited conversation to collaborators May 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

@meganrogge meganrogge

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-find Relating the terminal's find widget verified Verification succeeded
Projects
None yet
Milestone
April 2022
5 participants
@Tyriar @rzhao271 @gregvanl @meganrogge and others