Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

when there are many find matches, the overview ruler is not useful #145787

Closed
meganrogge opened this issue Mar 22, 2022 · 4 comments
Closed

when there are many find matches, the overview ruler is not useful #145787

meganrogge opened this issue Mar 22, 2022 · 4 comments
Assignees
@Tyriar @meganrogge
Labels
terminal-find Relating the terminal's find widget under-discussion Issue is under discussion for relevance, priority, approach
Milestone
March 2022

Comments

@meganrogge
Copy link
Contributor

meganrogge commented Mar 22, 2022 •
edited
Loading

Testing #145629

Screen Shot 2022-03-22 at 3 24 17 PM
@meganrogge meganrogge added under-discussion Issue is under discussion for relevance, priority, approach terminal-find Relating the terminal's find widget labels Mar 22, 2022
@meganrogge meganrogge added this to the March 2022 milestone Mar 22, 2022
@meganrogge
Copy link
Contributor Author

meganrogge commented Mar 22, 2022 •
edited
Loading

when I search for a in the editor, the result is pretty similar. the editor has the advantage of usually having empty lines whereas we do not
Screen Shot 2022-03-22 at 3 44 27 PM

@meganrogge
Copy link
Contributor Author

maybe when there are matches on x % of the lines, we should only show a decoration if it's on that line y times or more?

@Tyriar
Copy link
Member

Tyriar commented Mar 22, 2022

I think it's fine and working as designed, it tells you there are a lot results just like in the editor when it's full. You can either refine the search or maximize the terminal.

@meganrogge
Copy link
Contributor Author

meganrogge commented Mar 22, 2022 •
edited
Loading

Yeah it looks close enough to that of the editor

@github-actions github-actions bot locked and limited conversation to collaborators May 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

@meganrogge meganrogge

Labels
terminal-find Relating the terminal's find widget under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Milestone
March 2022
Development

No branches or pull requests
2 participants
@Tyriar @meganrogge