Closed
Description
Currently pty.js drives communication to and from the terminal's shell process but there are some issues with the way it's setup:
- To get it building with the newer node.js and to integrate with our Windows code signing I was forced to fork it to Tyriar/pty.js.
- The fork is a fork (Tyriar/pty.js) of a fork (platformio/pty.js) of a fork (jeremyramin/pty.js) of the original (chjj/pty.js) 😕 and it probably doesn't have to be.
- The original is not really maintained anymore.
The current commit being used is on a branch called prebuilt but the prebuilt assets were removed to get signing working on Tyriar/pty.js.The prebuilt branch was copied over the master branch https://github.com/Tyriar/pty.js/tree/master- All versions of pty.js depends on a fork (peters/winpty) of a very old version of rprichard/winpty which includes quite a few changes, including changes to the API. I believe this old version of winpty is the root cause for several windows-specific terminal issues.
- We should publish to Tyriar/pty.js to npm, particularly since it now has more consumers than just vscode https://github.com/Tyriar/pty.js/issues/9