Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Large notebook text outputs can't be wrapped #136184

Closed
thanhph111 opened this issue Oct 31, 2021 · 4 comments · Fixed by #140944
Closed

Large notebook text outputs can't be wrapped #136184

thanhph111 opened this issue Oct 31, 2021 · 4 comments · Fixed by #140944
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders notebook-output verified Verification succeeded
Milestone

Comments

@thanhph111
Copy link

thanhph111 commented Oct 31, 2021

Does this issue occur when all extensions are disabled?: Yes

As described in the title and the clip below will say the rest, the canvas seems overwhelmed with the output and doesn't wrap it.

Screencast.mp4

The log:

[36297:1031/112848.622152:ERROR:gl_utils.cc(314)] [.RendererMainThread-0x1414a4079800] GL_INVALID_FRAMEBUFFER_OPERATION: Draw framebuffer is incomplete

Because the lower trimmed part are wrapped, it thinks it don't have to show the scrollbar so we can't view the rest if the line is long enough. This is critical.

image

If we put some colors, we will see the lines overflow at the edge:

Screenshot

Smaller outputs are fine:

Screenshot

System info

Version: 1.62.0-insider
Commit: ff1e16e
Date: 2021-10-29T07:49:33.336Z
Electron: 13.5.1
Chrome: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Linux x64 5.11.0-38-generic

I haven't got a chance to test on other OSs.

This is my test notebook: https://gist.github.com/thanhph111/b6471bfa16603e56af351447c3cd29de.

@rebornix rebornix added bug Issue identified by VS Code Team member as probable bug notebook-output labels Nov 2, 2021
@rebornix rebornix added this to the November 2021 milestone Nov 2, 2021
@rebornix rebornix added feature-request Request for new features or functionality and removed bug Issue identified by VS Code Team member as probable bug labels Nov 2, 2021
@greazer greazer added bug Issue identified by VS Code Team member as probable bug nb-golden and removed feature-request Request for new features or functionality labels Nov 11, 2021
@greazer
Copy link
Member

greazer commented Nov 12, 2021

@rebornix, this is just a bug, but could probably be considered as part of the discussion about microsoft/vscode-jupyter#7096.

@rebornix rebornix modified the milestones: November 2021, On Deck Dec 1, 2021
@greazer
Copy link
Member

greazer commented Dec 16, 2021

@thanhph111, thanks for the feedback. What are your thoughts on the current behavior, where we supply a link at the top of the output that allows you to open the output in a separate editor tab? This behavior can indirectly essentially solve problems like this.

@thanhph111
Copy link
Author

@greazer It's definitely a good design. The issue actually doesn't stop me from doing my job. My opinion is, as you said, it's just a bug 😄 - and I just want to let you know.

@rchiodo
Copy link
Contributor

rchiodo commented Jan 18, 2022

@rebornix I'm taking this with the assumption you're not currently looking at it.

@rchiodo rchiodo assigned rchiodo and unassigned rebornix Jan 18, 2022
@rzhao271 rzhao271 modified the milestones: On Deck, January 2022 Jan 28, 2022
@rzhao271 rzhao271 added the verified Verification succeeded label Jan 28, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Mar 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders notebook-output verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants
@rebornix @rzhao271 @greazer @rchiodo @thanhph111 and others