Support reconnect in tasks

[Tyriar]

Terminals now reconnect when reloading local or remote windows. If a task is running at the time this will still reconnect the terminal but not restore the task, for example the VS Code core watch task results in this:

cc @meganrogge

[alexr00]

Yes, this would be great. I thought @alexdima had done some work to make sure that task terminals were not restored for now though? Since we cannot restore the task now, we decided this was the best behavior for now.

[alexdima]

@alexr00 I think what we did was for restored remote terminals, while this issue might be about restoring terminals with local windows.

[Tyriar]

Looks like the disabling in remote is here:

vscode/src/vs/workbench/contrib/terminal/browser/remoteTerminalService.ts

Line 157 in dda96b6

!this._shellLaunchConfig.isFeatureTerminal && this._configHelper.config.enablePersistentSessions,

We don't have this for local atm, should we add it? Isn't it good that the task terminals still get restored, despite not being linked to the task system?

[alexr00]

I think having "orphaned" task terminals is not a good behavior, and it would be better if they simply didn't restore until we have a good story. For example, if a user has a task that runs automatically when a folder is opened and their terminal restored then they could get weird behavior because now they have the old orphaned task running and the new task running.

[Tyriar]

👍 disabling in #117578

[Tyriar]

This would be really nice to have. Right now all I need to do to get back up and running after reloading the window is ctrl+shift+b. This isn't that big of a deal for the VS Code repo or other repos I work in as they're fairly small, but larger projects that don't have the daemon worker system it will mean no more rebuilding after reloads.