Skip to content

Proposal for updating commenting area for diffs #115808

Closed

Description

I was exploring ways to improve the PR experience in VS Code and one of the ideas involved updating the glyph area for comments. Currently we show a gray bar and a unicode + and that don't look very pretty.

Current

image

Proposal

A couple of things I explored:

  • Moving glyph area to the left of line numbers. This helps create separation between between the scm indicators and a clear area for adding comments.
  • Adding button for adding and view comments. This follows a similar pattern on GitHub for reviewing changes.
  • Hiding diff chunk areas. This reduces the visual noise and I think most people will be commenting on changed lines in the PR as opposed to lines that are not related
  • Adding color to the + and - changes to look visually pleasing

Kapture 2021-02-04 at 16 36 03

Unsure who should I assign to so assigning to @rebornix and @alexdima for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

Labels

commentsComments Provider/Widget/Panel issuesfeature-requestRequest for new features or functionalityinsiders-releasedPatch has been released in VS Code Insiderson-testplanuxUser experience issues

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions